Fix empty run ID silently matching first run - #33
Merged
Conversation
'toolu_abc'.endswith('') is always True, so 'agentrace show ""'
matched any run instead of erroring. Added a failing test first,
then a check that exits 1 with a usage error on stderr when args.id
is empty.
Closes AgentPostmortem#1
|
Welcome, @tomasgiorgi, and thanks for your first pull request to Agentrace. A quick look at CONTRIBUTING.md covers how things are set up and run here. I'll review this shortly. Ask anything in the thread if something is unclear. |
|
Merged, @tomasgiorgi. Thank you for taking the time. Genuinely helpful change for Agentrace. If this project helps you out, a star helps others find it too. Happy to see more from you whenever you have the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
'toolu_abc'.endswith('') is always True, so 'agentrace show ""' matched any run instead of erroring. Added a failing test first, then a check that exits 1 with a usage error on stderr when args.id is empty.
Changes
show ""exits nonzero with a usage error.args.idincmd_showthat prints an error to stderr and returns 1 before matching runs.Checklist
Closes #123)Closes #1