Skip to content

Fix empty run ID silently matching first run #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
royalpinto007 merged 1 commit into from
Sep 8, 2026
Merged

Fix empty run ID silently matching first run #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions agentrace/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@ def cmd_check(args) -> int:

def cmd_show(args) -> int:
runs = _load(args)
if args.id == "":
console.print("[red]Please provide a run ID[/]", file=sys.stderr)
return 1
match = [r for r in runs if r.tool_use_id.endswith(args.id)]
if not match:
console.print(f"[red]No run matching {args.id!r}[/]")
Expand Down
8 changes: 8 additions & 0 deletions tests/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,14 @@ def test_empty_result_names_selected_file(tmp_path):
assert result.returncode == 0
assert "No subagent runs found." in result.stdout
assert f"Looked in {transcript}." in result.stdout

def test_show_empty_id_errors(tmp_path):
transcript = tmp_path / "empty.jsonl"
transcript.write_text("")
result = run_cli("--file", str(transcript), "show", "")

assert result.returncode == 1
assert "Please provide a run ID" in result.stderr


def test_empty_result_names_selected_directory(tmp_path):
Expand Down
Loading