Convert all locale files to MiniMessage - #33
Merged
Conversation
BentoBox text is MiniMessage now; the &-codes still parse, but leaving
the files in the old format is what makes formatting bugs possible —
anything that has to build a fragment and put it into a translation has
to guess which format the line is in.
Converted with BentoBox's own Util.legacyToMiniMessage, so each value
now says exactly what the runtime was already rendering, then tidied up:
a straight conversion closes and immediately reopens a tag wherever the
old text repeated a colour code, which is every line of a multi-line
description.
Verified by rendering all 1582 values before and after and comparing the
style of every character: no value moved. Placeholder checks report the
same 47 pre-existing issues as before, none new.
Ten values across vi, tr, it, es, fr, uk and ja were left alone: they
contain a broken colour code ("& c", "&un", "& l") that never rendered
as colour and still doesn't. Worth a translator's eye, separately.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017EZEwab2kL4i1FNnBYvSmp
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows the formatting bug found while reviewing the chunks dialog: with locale text moving to MiniMessage, files left in legacy
&-codes are what make those bugs possible, because any code that builds a fragment for a translation has to guess which format the target line is in.All 18 locale files are now MiniMessage.
How
Converted with BentoBox's own
Util.legacyToMiniMessage, so each value now literally says what the runtime was already rendering — no hand translation of colour codes. Then tidied: a straight conversion closes and immediately reopens a tag wherever the old text repeated a colour code (every line of a multi-line flag description, every run split by a placeholder), so</aqua><aqua>seams are closed up.Verification
<bold>inside<green>instead of the reverse, which is the same thing to a player.)"on"/"off",wrap-at: '50') all survive the round trip — those quotes matter, unquotedon:would load as a boolean key.Left alone deliberately
Ten values in vi, tr, it, es, fr, uk and ja contain a broken colour code —
& c,& l,&un bloc— that never rendered as colour. They still render as literal text, exactly as today. Fixing them would change what players see, so that is a translator's call, not this PR's.Base
Stacked on
feature/chunks-map-dialog(#32) since both touch the locale files; GitHub will retarget this todevelopwhen that merges.🤖 Generated with Claude Code
https://claude.ai/code/session_017EZEwab2kL4i1FNnBYvSmp