Use new (spec) input editors to replace legacy editors - #163
Conversation
|
Bug 1 #164 — MarkovChainDistribution showing IID in the dropdown: Fixed with a small, dedicated MarkovChainDistributionInputEditor (new class, registered for MarkovChainDistribution.class specifically) that never builds a combo box. TensorDistributionInputEditor/IIDInputEditor stay untouched, and MarkovChainDistribution is not registered as a subtemplate — so its row shows no dropdown at all, and it never appears as an alternative for other vectors either. Bug 2 #165 — estimate checkbox on Uniform/LogUniform/BoundedReal's lower/upper: Fixed in ScalarInputEditor.java — the checkbox is forced invisible for a ScalarDistribution's "lower"/"upper" inputs. Bug 3 #166 — CoalescentExtendedBayesianSkyline broken: Fixed with no deprecated classes. TreePriors.xml's indicatorsPrior.alltrees now wires IntSum directly into the spec-package Poisson's param input (mirroring the existing pattern in ClockModels.xml's RRateChangesPrior), instead of the old Prior+legacy-Poisson wrapper. Verified via SimpleTreePriorTest's real BEAUti click-through. |
See #157 and fix #162
Replaces the deprecated
ParameterInputEditorwith the specScalarInputEditor/VectorInputEditorpair, and removes the now-unusedLegacyStandard.xmltemplate.ParameterInputEditoras an InputEditor service; registerspec.VectorInputEditor.BeautiDoc.scrubAll()resolvingSiteModelInputEditor.customConnectorto the legacy class instead of
spec.SiteModelInputEditor; updateSubstModels.xml/Standard.xml connectors accordingly.
BranchRateModel.Baseinstead of specBaseRealScalarParaminsteadof
ScalarDistribution, so it never showed for a prior's ownhyperparameters (e.g. Gamma's alpha/theta)
not just the operator's parameter list; added
TensorDistributionInputEditorTest for Dirichlet incorrectly displayed in the Prior panel #160 (Dirichlet vs IID offering).
Follow-up not included here: VectorInputEditor has no hyperprior-reveal
branch, and BeautiConfig's hyperprior template still builds legacy
Prior/OneOnX/ScaleOperator objects instead of spec ones.