skills: canonical cluster names - #169
Conversation
Normalise the two Fellows-compute clusters onto their canonical names in the skill and tooling that people and agents read going forward. The rename is presentational and additive: - The skill's cluster table now leads with the canonical name, and lists the clusterkit back-compat aliases and the ssh host alongside it. The canonical clusterkit names ship in clusterkit 0.8.0, so a venv pinned below that still needs an alias — called out where the serve-venv pin is discussed. - SSH instructions and the config template lead with the canonical host, and keep the previous alias on the same `Host` line so existing scripts keep resolving. The template gains a block for the second cluster's login host, sharing the existing options block (user, keepalives, identity file). - `scancel-mine` help and error text name the new hosts. `--via` is a pass through to `ssh`, so behaviour is name-agnostic and unchanged. Deliberately untouched: the Slurm QoS names, which are cluster-side and only look like the rename; and the skill's own directory name, which is a stable identifier referenced by settings and hooks.
DJRHails
left a comment
There was a problem hiding this comment.
Automated review — findings posted inline. P1/P2 threads resolve as their fixes land.
Review SummaryThis PR merged while the review was in flight, so the fixes landed as a follow-up: PR #170 (commit e5d5075, branch
Also worth knowing (no thread): the PR description's "ships in clusterkit 0.8.0" is the same unshipped claim as F1. Verified: clusterkit facts read from Verdict: comment |
Normalises the two Fellows-compute clusters onto their canonical names across the
skill and tooling that people and agents read going forward. Presentational and
additive — nothing changes which machine anything reaches.
What changed
carries the clusterkit back-compat aliases and the ssh host in their own columns.
The clusterkit-side rename ships in clusterkit 0.8.0, so a venv pinned below
that still needs an alias; that's called out where the serve-venv pin is
discussed, since a mismatch there surfaces as a
KeyErroron the cluster name.The decorator/
--targetexamples move to the canonical names.the previous alias on the same
Hostline, so existing scripts keep resolving.The template gains a block for the second cluster's login host, sharing the
existing options block (user, keepalives, identity file) rather than inventing
new auth wiring.
scancel-mine— help and error text name the new hosts.--viais apass-through to
ssh, so behaviour is name-agnostic and unchanged; its test'shost string moved too (the suite's
sshstub drops the host).Deliberately untouched
skill now says so explicitly, next to the ssh-alias note, so the next reader
doing a sweep doesn't rewrite them.
and a guard hook.
sshmodule: its template ships nocluster entries at all, and the rendered config is gitignored and machine-local.
Checks
shellcheckclean; the scancel-mine, scancel-guard and prose-lint suites pass,and the full 12-hook pre-commit run (incl. gitleaks/TruffleHog and the glassine
encryption checks) passes. Staged blobs for the encrypted tree verified as
ciphertext.
via claude @ taffy