Skip to content

skills(runpod-ant-cluster): clusterkit names as shipped; EUR QoS map - #170

Open
DJRHails wants to merge 2 commits into
mainfrom
review-169-clusterkit-names
Open

DJRHails wants to merge 2 commits into
mainfrom
review-169-clusterkit-names

Conversation

@DJRHails

Copy link
Copy Markdown
Owner

Follow-up to #169, which merged while its review was in flight. Two findings from that review, both in the cluster skill:

  • clusterkit names. clusterkit main (0.7.0, pushed 2026-09-11) keys KNOWN_CLUSTERS by ant-bulbasaur/ant-charmander with ant/eur as aliases. No tag or branch ships the bare bulbasaur/charmander names or a 0.8.0, so the Cluster(...)/--target/backend= examples skills: canonical cluster names #169 moved to the bare names raise KeyError on every clusterkit an agent can install. The table now carries a "clusterkit name (aliases)" column with the shipped names, the selector paragraph says the bare names are ssh hosts only, and the venv bullet and decorator example return to ant-charmander. The ssh-host rename from skills: canonical cluster names #169 is untouched.
  • EUR QoS row. high maps to high-eur, not normal-eur, and dev to dev-eur, matching clusterkit's qos_map (which documents why normal-eur is the wrong target: preemptible). The QoS bullet skills: canonical cluster names #169 added already listed all four names; the row now agrees with it.

Checks: full 12-hook prek run --all-files passes (gitleaks, TruffleHog, glassine rule and encryption checks, all behaviour suites). The committed blob for the encrypted skill file verified as ciphertext.

via gantry

- F1 (P1, fixed): clusterkit's canonical names on main (0.7.0) are
  ant-bulbasaur/ant-charmander; no release or branch ships bare
  bulbasaur/charmander, so the table, selector paragraph, venv bullet and
  decorator example return to the shipped clusterkit names. The bare names
  stay as the ssh hosts, which the template defines.
- F2 (P2, fixed): EUR QoS row now matches clusterkit's qos_map
  (high->high-eur, dev->dev-eur), not normal-eur.

@DJRHails DJRHails left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — findings posted inline. P1/P2 threads resolve as their fixes land.

via gantry

Comment thread modules/agents/skills/runpod-ant-cluster/SKILL.md
Comment thread modules/agents/skills/runpod-ant-cluster/SKILL.md
Comment thread modules/agents/skills/runpod-ant-cluster/SKILL.md
- F1 (P1, fixed): clusterkit#74 (0.8.0, merged 2026-09-13T19:57Z, before
  this PR opened) made the bare bulbasaur/charmander the canonical
  KNOWN_CLUSTERS keys and demoted ant-*/ant/eur to aliases; the table
  column, selector paragraph and decorator example now describe that,
  and name the pre-#74 pin (touchstone's 82a2aac, 0.7.0) that still
  needs ant-charmander.
- F2 (P2, fixed): the venv bullet now says which name needs which
  clusterkit commit (#16 for ant-charmander, #74 for charmander), and
  points at scripts/provision-serve-venv.sh, the path touchstone has.
- F3 (P3, fixed): the cross-cluster client anecdote names an EUR qos
  clusterkit actually renders (high-eur), not normal-eur.
@DJRHails

Copy link
Copy Markdown
Owner Author

Review Summary

# Severity Finding Resolution
F1 P1 The PR's premise is inverted as of 2026-09-13T19:57Z: clusterkit#74 (0.8.0) made the bare bulbasaur/charmander the canonical KNOWN_CLUSTERS keys with ant-*/ant/eur as aliases, two and a half minutes before this PR opened. The table column, selector paragraph and decorator example said the opposite. Fixed in b0886c9: the column and paragraph name the bare canonical pair plus aliases, and state that a pre-#74 pin (touchstone's uv.lock at 82a2aac, 0.7.0, spelling ant-charmander throughout) still needs ant-charmander.
F2 P2 Venv bullet: Cluster("ant-charmander") does not KeyError on any pin since clusterkit#16 (2026-07-20); the miss a reader hits today is bare charmander on a pre-#74 pin. Also serving/provision-serve-venv.sh does not exist in touchstone; the script is scripts/provision-serve-venv.sh. Fixed in b0886c9: names which spelling needs which commit (#16 / #74) and corrects the path.
F3 P3 Cross-cluster client anecdote names normal-eur, a qos clusterkit has not rendered since clusterkit#51 (high→high-eur). Fixed in b0886c9 (one-word change, file already open).

Kept from the PR as correct: the EUR QoS row (low→low-eur, high→high-eur, dev→dev-eur) matches _CHARMANDER.qos_map in src/clusterkit/config.py at clusterkit main exactly.

Verified: cloned DJRHails/clusterkit at 81f3bef8 and read config.py (CLUSTER_ALIASES, _CANONICAL_CLUSTERS, KNOWN_CLUSTERS, qos_map), api.py named_cluster, cli.py --target choices, pyproject.toml version 0.8.0 (0.7.0 at the parent ecdc8970); git tag empty; git log -S dates the ant-* names to #16 (58465ad4) and ant/eur to 11813dcb. Read touchstone's pyproject.toml/uv.lock (pin 82a2aac, version 0.7.0, five commits before #74) and grepped its Cluster(/--target spellings. Ran the full 12-hook prek run on the staged change: all passed (gitleaks, TruffleHog, glassine rule and encryption checks, all behaviour suites). Confirmed the committed blob for the skill file is a glassine ciphertext envelope. No CI beyond the hooks applies to this file.

Follow-up (not in this PR): touchstone's clusterkit pin is five commits behind main; once it moves past #74 the skill's "keep to ant-charmander in touchstone" sentence should be dropped.

Fix commit: b0886c9
Reviewed head: b0886c9

Verdict: approve

via gantry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant