Conversation
- F1 (P1, fixed): clusterkit's canonical names on main (0.7.0) are ant-bulbasaur/ant-charmander; no release or branch ships bare bulbasaur/charmander, so the table, selector paragraph, venv bullet and decorator example return to the shipped clusterkit names. The bare names stay as the ssh hosts, which the template defines. - F2 (P2, fixed): EUR QoS row now matches clusterkit's qos_map (high->high-eur, dev->dev-eur), not normal-eur.
DJRHails
left a comment
There was a problem hiding this comment.
Automated review — findings posted inline. P1/P2 threads resolve as their fixes land.
- F1 (P1, fixed): clusterkit#74 (0.8.0, merged 2026-09-13T19:57Z, before this PR opened) made the bare bulbasaur/charmander the canonical KNOWN_CLUSTERS keys and demoted ant-*/ant/eur to aliases; the table column, selector paragraph and decorator example now describe that, and name the pre-#74 pin (touchstone's 82a2aac, 0.7.0) that still needs ant-charmander. - F2 (P2, fixed): the venv bullet now says which name needs which clusterkit commit (#16 for ant-charmander, #74 for charmander), and points at scripts/provision-serve-venv.sh, the path touchstone has. - F3 (P3, fixed): the cross-cluster client anecdote names an EUR qos clusterkit actually renders (high-eur), not normal-eur.
Review Summary
Kept from the PR as correct: the EUR QoS row ( Verified: cloned Follow-up (not in this PR): touchstone's clusterkit pin is five commits behind Fix commit: b0886c9 Verdict: approve |
Follow-up to #169, which merged while its review was in flight. Two findings from that review, both in the cluster skill:
main(0.7.0, pushed 2026-09-11) keysKNOWN_CLUSTERSbyant-bulbasaur/ant-charmanderwithant/euras aliases. No tag or branch ships the barebulbasaur/charmandernames or a 0.8.0, so theCluster(...)/--target/backend=examples skills: canonical cluster names #169 moved to the bare names raiseKeyErroron every clusterkit an agent can install. The table now carries a "clusterkit name (aliases)" column with the shipped names, the selector paragraph says the bare names are ssh hosts only, and the venv bullet and decorator example return toant-charmander. The ssh-host rename from skills: canonical cluster names #169 is untouched.highmaps tohigh-eur, notnormal-eur, anddevtodev-eur, matching clusterkit'sqos_map(which documents whynormal-euris the wrong target: preemptible). The QoS bullet skills: canonical cluster names #169 added already listed all four names; the row now agrees with it.Checks: full 12-hook
prek run --all-filespasses (gitleaks, TruffleHog, glassine rule and encryption checks, all behaviour suites). The committed blob for the encrypted skill file verified as ciphertext.via gantry