Load t8code_jll only if preferences say so - #139
Merged
Merged
Conversation
ranocha
requested changes
Sep 16, 2026
ranocha
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Can we have a test for this to avoid regressions in the future?
Collaborator
|
We should probably do the same in P4est.jl, see also trixi-framework/P4est.jl#166. |
Collaborator
|
@benegee Since it appears that this is needed (e.g., for your multi-GPU tests), shall we already merge this PR and release a new version now so that you have a bit more time to add a new regression test for this? |
ranocha
approved these changes
Sep 22, 2026
Collaborator
Author
Collaborator
You could change the setup of Aqua.jl depending on the environment variable determining which test to run. |
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading
t8code_jllunconditionally can cause some trouble when system's MPI should be used. For example, it will always load MPI jll packages, which might cause conflicts. In case ofOpenMPI_jllalsoOPAL_PREFIXwill be overwritten.