Skip to content

Load t8code_jll only if preferences say so - #139

Merged
ranocha merged 1 commit into
mainfrom
bg/avoid-loading-t8code_jll
Sep 23, 2026
Merged

ranocha merged 1 commit into
mainfrom
bg/avoid-loading-t8code_jll

Conversation

@benegee

@benegee benegee commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Loading t8code_jll unconditionally can cause some trouble when system's MPI should be used. For example, it will always load MPI jll packages, which might cause conflicts. In case of OpenMPI_jll also OPAL_PREFIX will be overwritten.

@ranocha ranocha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can we have a test for this to avoid regressions in the future?

Comment thread src/Libt8.jl
@JoshuaLampert

Copy link
Copy Markdown
Collaborator

We should probably do the same in P4est.jl, see also trixi-framework/P4est.jl#166.

@ranocha

ranocha commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

@benegee Since it appears that this is needed (e.g., for your multi-GPU tests), shall we already merge this PR and release a new version now so that you have a bit more time to add a new regression test for this?

@benegee

benegee commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

I was hoping to get #143 done, but at the moment I am not sure how to do it properly.

I am fine with merging this PR though. What I realized in #143 is that Aqua test break because t8code_jll, a direct dependency, is not loaded anymore.

@ranocha
ranocha merged commit 85c477b into main Sep 23, 2026
18 checks passed
@ranocha

ranocha commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

What I realized in #143 is that Aqua test break because t8code_jll, a direct dependency, is not loaded anymore.

You could change the setup of Aqua.jl depending on the environment variable determining which test to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants