Skip to content

CI test with system MPI and local t8code installation - #143

Merged
benegee merged 46 commits into
mainfrom
bg/test-external-t8code
Sep 25, 2026
Merged

benegee merged 46 commits into
mainfrom
bg/test-external-t8code

Conversation

@benegee

@benegee benegee commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Motivated by #139 and by P4est.jl's tests, this PR adds tests using system's MPI libraries and locally compiled t8code libraries.

@benegee
benegee marked this pull request as draft September 22, 2026 07:54
@benegee benegee closed this Sep 22, 2026
@benegee benegee reopened this Sep 22, 2026
@JoshuaLampert

Copy link
Copy Markdown
Collaborator

Can you explain why there are problems here with the system MPI tests in CI that we do not have in P4est.jl? Your comment above about the version mismatch would also apply to P4est_jll.jl and P4est.jl, wouldn't it (see, e.g. here)? Or what am I missing?

@benegee

benegee commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator Author

Can you explain why there are problems here with the system MPI tests in CI that we do not have in P4est.jl?

I think this is the reason:
https://github.com/JuliaPackaging/Yggdrasil/blob/c47cf70b997286ebdf74548e31284085514d1865/P/P4est/build_tarballs.jl#L84-L93

Although OpenMPI_jll is listed as a dependency, it actually isn't.

@JoshuaLampert

JoshuaLampert commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Ah yes, maybe. These issues are too long ago for my brain to remember the details, but yes, there was something. A similar workaround in the build script for t8code_jll.jl in Yggdrasil as the one you linked above for P4est_jll.jl does not work?

@benegee

benegee commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator Author

A similar workaround in the build script for t8code_jll.jl in Yggdrasil as the one you linked above for P4est_jll.jl does not work?

It would probably. It's just that when I started revising the Yggdrasil receipt I was eager to enable as much as possible.

@benegee
benegee marked this pull request as ready for review September 24, 2026 09:22
Comment thread .github/workflows/test.yml
Comment thread .github/workflows/test.yml
Comment thread test/Project.toml
Comment thread test/test_aqua.jl
Comment thread test/test_aqua.jl
@benegee benegee changed the title [WIP] CI test with system MPI and local t8code installation CI test with system MPI and local t8code installation Sep 24, 2026
@benegee

benegee commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator Author

I'm happy with the current state. Maybe you want to have a look, @JoshuaLampert @spenke91 .

@JoshuaLampert JoshuaLampert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! The whole setup seems a bit fragile, but if it the only way we see at the moment to run tests with a system MPI, I would be fine with it. Did you already let an LLM review this?

@benegee

benegee commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator Author

The whole setup seems a bit fragile

True!
Thanks for your approval, anyway!

Did you already let an LLM review this?

I just did, but it just raised two false positives.
In fact, the t8code part of the workflow was copied from libtrixi. And Claude helped with pinpointing the dlopen issue.

@benegee
benegee merged commit 78bd047 into main Sep 25, 2026
21 checks passed
@JoshuaLampert
JoshuaLampert deleted the bg/test-external-t8code branch September 25, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants