CI test with system MPI and local t8code installation - #143
Conversation
This reverts commit c4adcf8.
|
Can you explain why there are problems here with the system MPI tests in CI that we do not have in P4est.jl? Your comment above about the version mismatch would also apply to P4est_jll.jl and P4est.jl, wouldn't it (see, e.g. here)? Or what am I missing? |
I think this is the reason: Although |
|
Ah yes, maybe. These issues are too long ago for my brain to remember the details, but yes, there was something. A similar workaround in the build script for t8code_jll.jl in Yggdrasil as the one you linked above for P4est_jll.jl does not work? |
It would probably. It's just that when I started revising the Yggdrasil receipt I was eager to enable as much as possible. |
|
I'm happy with the current state. Maybe you want to have a look, @JoshuaLampert @spenke91 . |
JoshuaLampert
left a comment
There was a problem hiding this comment.
Thanks a lot! The whole setup seems a bit fragile, but if it the only way we see at the moment to run tests with a system MPI, I would be fine with it. Did you already let an LLM review this?
True!
I just did, but it just raised two false positives. |
Motivated by #139 and by P4est.jl's tests, this PR adds tests using system's MPI libraries and locally compiled t8code libraries.