Fix CUDA device index preservation in standardize_device_string#364
Merged
Conversation
Previously, standardize_device_string mapped any cuda:X string to cuda:0, causing Warp kernels to launch on the wrong GPU when users specified a non-zero CUDA device (e.g., --device cuda:4). Now only bare 'cuda' is normalized to 'cuda:0', and existing indices are preserved.
yuecideng
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes embodichain.utils.device_utils.standardize_device_string so that only the bare "cuda" device string is normalized to "cuda:0", preserving explicit CUDA device indices like "cuda:4" to avoid Warp/Torch device mismatches in CUDA-based solvers.
Changes:
- Update
standardize_device_stringto special-case only"cuda"(not all"cuda:*"strings). - Add unit tests covering CPU, CUDA without index, and CUDA with explicit indices for both
strandtorch.deviceinputs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
embodichain/utils/device_utils.py |
Adjusts CUDA device string normalization to preserve non-zero indices. |
tests/utils/test_device_utils.py |
Adds test coverage for standardize_device_string behavior across CPU/CUDA variants. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+19
to
+20
| import pytest | ||
| import torch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
standardize_device_stringso it preserves non-zero CUDA device indices instead of forcing everycuda:Xtocuda:0.Previously, when running with
--device cuda:4, tensors were placed oncuda:4but Warp kernels were launched oncuda:0, causing aRuntimeErrorduring environment reset in solvers such as OPW.Dependencies: None
Type of change
Screenshots
N/A
Checklist
black .command to format the code base.