test(fixtures): isolate unreadable history and repository discovery

[dnlrsls]

PR Type

• Maintenance/tooling (type:chore)

Summary

Preserve exact-path unreadable-file rejection and bytes with restored EACCES fallback; isolate Git discovery with an outer barrier and a positive nested-parent witness.

Changes

Edit surface	Outcome
tests/history-gc.test.ts; tests/session-worktree-registry.test.ts; docs/isolated-filesystem-fixtures.md	filesystem work unit

Test Plan

Independent38/38, zero skips; parent38/38. POSIX real-permission branch unexecuted.

Chain Context

Field	Value
Chain	path-fence safety follow-ups
Tracker PR	#2048 (draft/no-merge)
Position	1 of3
Base	feat/path-fence-safety
Depends on	#2048; #1610 approved pin
Follow-up	#2050 launcher
Review budget	81 /400
Starts at	immediate parent branch; inherited foundation excluded
Ends with	filesystem unit commit 5cccc9c0eef42ef7af84b75ab67073e29c14dfa3

#1610 approved pin -> #2048 tracker
  📍 #2049 filesystem
    #2050 launcher
      #2051 security

Scope / rollback / autonomy

Includes only filesystem unit and accompanying tests/docs. Rollback reverts this unit's listed files/commit without reverting prior slices. Excludes new production launcher/history/registry changes, unclassified corpus fixes, merge and automatic base update. CI expected-green is NOT asserted; drafts remain blocked from integration until CI/base decisions.

Linked Issue

Closes #1660
Related: #1659 (primary fix is inherited from #1610, not authored here). Both issues retain status:approved.

Verification limits

• Windows local affected-file seam: 178 pass, 0 fail, 8 existing skips. Typecheck: no regressions (187 recorded diagnostics).
• Independent filesystem unit: 38/38. Independent launcher: 122 pass/1 isolation failure/8 unchanged skips; a separately authorized single-case recheck passed1/1 after removing ancestor-dependency contamination. This is not rewritten as a full-file-green verifier run.
• Initial full pnpm test was stopped with181 provisional failure records, without a final summary. Remaining corpus is unclassified; no blanket inherited-failure or full-suite-green claim.
• Local POSIX-host execution was not run; Ubuntu CI verify has now succeeded. Actual Windows console Ctrl+C E2E remains unexecuted. Windows interruption uses a modeled event on the real launcher, with real child termination.
• Provider contract, runtime harness and generated-module checks passed locally. Remote CI completed: tracker docs(odd): track pinned path-consent safety correction chain #2048, filesystem test(fixtures): isolate unreadable history and repository discovery #2049 and security fix(safety): deny unavailable confirmation capability and pin schema coverage #2051 green (including their package/packed-install jobs). Launcher test(launcher): make Windows execution and interruption fixtures faithful #2050 fails macOS cleanup in tests/gentle-agents.test.ts:5430 (ENOTEMPTY); its other jobs pass. Cause not classified; no retry or source correction. Chain integration remains blocked.
• No shell scripts or skills changed; shellcheck/skill-change validation are N/A.
• Draft/no-merge: fix(safety): require consent for path tools outside the session worktree (#1305) #1610 is OPEN and moved to e262890dcb5f69ff6b7289f7baa491ec72a9bc03; this chain retains the explicitly approved pin 162c9bda89242a73f5ed55d7383a8d96ad19660d. Reconcile the base before integration.

Contributor Checklist

• Linked approved issue and added exactly one matching type label.
• Conventional commits; no Co-Authored-By trailers.
• Tests/docs accompany their behavior; no production launcher/history/registry changes in fixture units.
• Modified-shell/skill checks: N/A, none modified.
• Complete CI green and base reconciled before merge.

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}

[barbatdev]

Fleet review (qwen)

Test fixtures: isolate unreadable history and repository discovery. Preserve EACCES fallback, outer barrier for Git discovery. Part 1/3 of path-fence safety chain. 38/38 tests pass.

No findings.

Verdict: clean

[barbatdev]

Fleet review (deepseek)

Test-only fixture-isolation slice (#1660 follow-ups, position 1/3 of the path-fence chain): the history-GC unreadable-input test now restores fs.readFileSync/fs.openSync in finally and asserts byte-for-byte preservation of the sealed original, injecting a scoped EACCES only for that exact fixture path when real chmod 000 cannot seal the file (Windows/privileged POSIX); the session-worktree-registry fixture writes invalid .git metadata to stop Git discovering an ambient ancestor and adds a positive nested-parent witness. Monkeypatching is bounded to the sealed path, restored in finally, and the mock branches assert the denied reads actually happened, so a silently-unsealed input fails rather than passing. No defects found.

No findings.

Verdict: clean