test(launcher): make Windows execution and interruption fixtures faithful

[dnlrsls]

PR Type

• Maintenance/tooling (type:chore)

Summary

Adapt only fixture-owned Node mocks on Windows, preserving native missing/nonfixture/POSIX commands. Model Windows SIGINT delivery through private fixture IPC; retain normal exit130, no Pi launch and provisioning-child termination. POSIX still sends actual signals.

Changes

Edit surface	Outcome
tests/gentle-shell-bin.test.ts; tests/node-executable-fixture.test.ts; tests/support/node-executable-fixture.cjs; docs/launcher-test-fixtures.md	launcher work unit

Test Plan

Independent122/1/8 with isolation failure; authorized targeted correction1/1 resolves absence/PATH proof. Interrupt exit130/signal-null/no-Pi/child-ESRCH passes independently. Helper passes;8 existing skips unchanged.

Chain Context

Field	Value
Chain	path-fence safety follow-ups
Tracker PR	#2048 (draft/no-merge)
Position	2 of3
Base	test/path-fence-filesystem-fixtures
Depends on	#2049; #1610 approved pin
Follow-up	#2051 security
Review budget	149 /400
Starts at	immediate parent branch; inherited foundation excluded
Ends with	launcher unit commit 2916bbec15389558af12582bba36a119930d79be

#1610 approved pin -> #2048 tracker
  #2049 filesystem
    📍 #2050 launcher
      #2051 security

Scope / rollback / autonomy

Includes only launcher unit and accompanying tests/docs. Rollback reverts this unit's listed files/commit without reverting prior slices. Excludes new production launcher/history/registry changes, unclassified corpus fixes, merge and automatic base update. CI expected-green is NOT asserted; drafts remain blocked from integration until CI/base decisions.

Linked Issue

Closes #1660
Related: #1659 (primary fix is inherited from #1610, not authored here). Both issues retain status:approved.

Verification limits

• Windows local affected-file seam: 178 pass, 0 fail, 8 existing skips. Typecheck: no regressions (187 recorded diagnostics).
• Independent filesystem unit: 38/38. Independent launcher: 122 pass/1 isolation failure/8 unchanged skips; a separately authorized single-case recheck passed1/1 after removing ancestor-dependency contamination. This is not rewritten as a full-file-green verifier run.
• Initial full pnpm test was stopped with181 provisional failure records, without a final summary. Remaining corpus is unclassified; no blanket inherited-failure or full-suite-green claim.
• Local POSIX-host execution was not run; Ubuntu CI verify has now succeeded. Actual Windows console Ctrl+C E2E remains unexecuted. Windows interruption uses a modeled event on the real launcher, with real child termination.
• Provider contract, runtime harness and generated-module checks passed locally. Remote CI completed: tracker docs(odd): track pinned path-consent safety correction chain #2048, filesystem test(fixtures): isolate unreadable history and repository discovery #2049 and security fix(safety): deny unavailable confirmation capability and pin schema coverage #2051 green (including their package/packed-install jobs). Launcher test(launcher): make Windows execution and interruption fixtures faithful #2050 fails macOS cleanup in tests/gentle-agents.test.ts:5430 (ENOTEMPTY); its other jobs pass. Cause not classified; no retry or source correction. Chain integration remains blocked.
• No shell scripts or skills changed; shellcheck/skill-change validation are N/A.
• Draft/no-merge: fix(safety): require consent for path tools outside the session worktree (#1305) #1610 is OPEN and moved to e262890dcb5f69ff6b7289f7baa491ec72a9bc03; this chain retains the explicitly approved pin 162c9bda89242a73f5ed55d7383a8d96ad19660d. Reconcile the base before integration.

Contributor Checklist

• Linked approved issue and added exactly one matching type label.
• Conventional commits; no Co-Authored-By trailers.
• Tests/docs accompany their behavior; no production launcher/history/registry changes in fixture units.
• Modified-shell/skill checks: N/A, none modified.
• Complete CI green and base reconciled before merge.

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}

[barbatdev]

Fleet review (qwen)

Test fixtures: make Windows execution/interruption fixtures faithful. Model Windows SIGINT through private fixture IPC, retain normal exit130. Part 2/3 of path-fence safety chain. 122/1/8 tests.

No findings.

Verdict: clean

[barbatdev]

Fleet review (deepseek)

Test/tooling-only slice that makes the Windows launcher and interruption fixtures faithful: a Windows-only Node-require preload maps disposable fixture shebang scripts, path-sensitive assertions use the corrected remediation home, and Windows SIGINT is modeled through private IPC while POSIX still sends the real signal, asserting the provisioning child is gone (ESRCH). Changes are confined to fixture-owned mocks and docs.

Question (1)

• CI macOS cleanup failure is reported but unclassified (tests/gentle-agents.test.ts:5430): The PR states CI for this slice fails macOS cleanup at tests/gentle-agents.test.ts:5430 with ENOTEMPTY while its other jobs pass, and that the cause was not classified. Since that file is not part of this diff, can you confirm whether the failure reproduces on the pre-change base (flaky/pre-existing) or is introduced by the fixture changes, before this slice is considered for integration?

Verdict: clean

[barbatdev]

Fleet review (qwen)

Test-only: makes Windows launcher test fixtures faithful by using a Windows-only preload for Node script mocks and modeling SIGINT through private IPC on Windows (instead of Node's child.kill which force-terminates). Retains POSIX native signals. 122/1/8 initial run with one isolation failure, then targeted correction 1/1. Part of the path-fence safety chain (#2048). Draft PR (no-merge).

No findings.

Verdict: clean