[KDM-CLI-FIX-321] fix: return non-zero on config set errors - #321
Conversation
|
Warning Review limit reachedNext included review available in 56 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository UI Review profile: QUIET Plan: Advanced Run ID: 📒 Files selected for processing (1)
Warning
|
utkarsh232005
left a comment
There was a problem hiding this comment.
Looks good! The changes accurately address Issue #263:
- Properly sets
process.exitCode = 1when an error is caught duringkdm config set, ensuring CI/CD scripts fail as expected. - Updates the note in
kdm config list(and the setup guide) to clarify that SMTP passwords must be supplied viaKDM_SMTP_PASSWORD.
LGTM!
There was a problem hiding this comment.
Gates Passed
3 Quality Gates Passed
See analysis details in CodeScene
Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Summary
Testing
Fixes #263