Skip to content

[KDM-CLI-FIX-321] fix: return non-zero on config set errors #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
utkarsh232005 merged 2 commits into from
Sep 23, 2026
Merged

[KDM-CLI-FIX-321] fix: return non-zero on config set errors #321

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dde11a
fix: return non-zero on config set errors
Akanshagore Sep 22, 2026
2ec0b77
Merge branch 'main' into fix/config-set-exit-code-263
utkarsh232005 Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions src/commands/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,9 +270,8 @@ const registerConfigSetCommand = (config: Command) => {
setConfig(key as any, finalValue);
console.log(chalk.green(`✓ Set ${key} to ${finalValue}`));
} catch (error) {
console.error(
chalk.red(`✗ Failed to set config: ${(error as Error).message}`),
);
console.error(chalk.red(`✗ Failed to set config: ${(error as Error).message}`));
process.exitCode = 1;
}
});
};
Expand Down Expand Up @@ -302,16 +301,8 @@ const registerConfigListCommand = (config: Command) => {
);
});
}

console.log(
chalk.gray('──────────────────────────────────────────────────'),
);

console.log(
chalk.dim(
'\n Note: SMTP password can be set either in config or via the KDM_SMTP_PASSWORD environment variable, which takes precedence if both are set.\n',
),
);
console.log(chalk.gray('──────────────────────────────────────────────────'));
console.log(chalk.dim('\n Note: SMTP passwords must be provided exclusively via the KDM_SMTP_PASSWORD environment variable.\n'));
});
};

Expand Down Expand Up @@ -372,7 +363,7 @@ const printEmailSmtpGuide = () => {
console.log(chalk.white(' 1. Find your provider SMTP settings before continuing.'));
console.log(chalk.white(' 2. Common hosts: smtp.gmail.com for Gmail, smtp.office365.com for Outlook.'));
console.log(chalk.white(' 3. Use port 587 for STARTTLS unless your provider says otherwise.'));
console.log(chalk.white(' 4. Set the SMTP password via the KDM_SMTP_PASSWORD environment variable.'));
console.log(chalk.white(' 4. Provide the SMTP password via the KDM_SMTP_PASSWORD environment variable.'));
console.log(chalk.dim(' Gmail accounts with 2FA usually require an App Password.'));
console.log(chalk.gray('──────────────────────────────────────────────────\n'));
};
Loading