Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is small and directly addresses the regression by ensuring font-size updates flow through changeFontSize(_:), with only a minor accessibility improvement suggested.
Pull request overview
This PR updates the macOS Settings font-size control to reliably propagate Stepper value changes on macOS 27 (where onEditingChanged is no longer firing as expected), ensuring font-size changes are persisted via the existing handler pathway (closes #1735).
Changes:
- Replaces
Stepper(..., onEditingChanged:)usage with a customBindingsetter that callschangeFontSize(_:). - Simplifies the Stepper initializer by removing the explicit
label:argument in favor of a trailing closure.
File summaries
| File | Description |
|---|---|
| MarkEditMac/Modules/Sources/FontPicker/FontPicker.swift | Routes Stepper updates through a Binding setter to ensure handlers.fontSizeDidChange is called on macOS 27. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1735.