Skip to content

[macOS 27] Fix onEditingChanged not working - #1736

Merged
cyanzhong merged 1 commit into
mainfrom
develop
Sep 7, 2026
Merged

[macOS 27] Fix onEditingChanged not working#1736
cyanzhong merged 1 commit into
mainfrom
develop

Conversation

@cyanzhong

Copy link
Copy Markdown
Contributor

Closes #1735.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is small and directly addresses the regression by ensuring font-size updates flow through changeFontSize(_:), with only a minor accessibility improvement suggested.

Pull request overview

This PR updates the macOS Settings font-size control to reliably propagate Stepper value changes on macOS 27 (where onEditingChanged is no longer firing as expected), ensuring font-size changes are persisted via the existing handler pathway (closes #1735).

Changes:

  • Replaces Stepper(..., onEditingChanged:) usage with a custom Binding setter that calls changeFontSize(_:).
  • Simplifies the Stepper initializer by removing the explicit label: argument in favor of a trailing closure.
File summaries
File Description
MarkEditMac/Modules/Sources/FontPicker/FontPicker.swift Routes Stepper updates through a Binding setter to ensure handlers.fontSizeDidChange is called on macOS 27.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread MarkEditMac/Modules/Sources/FontPicker/FontPicker.swift Outdated
@cyanzhong
cyanzhong merged commit 542f321 into main Sep 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Font Size Not Being Honored in Beta macOS 27

2 participants