Add color pattern to theme picker - #1739
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified that would block approval.
Pull request overview
Adds color-pattern swatches and light/dark grouping to the editor theme pickers.
Changes:
- Adds color palettes and simplified display names to built-in themes.
- Renders palette swatches in theme picker menu items.
- Adds localized section headers for light and dark themes.
File summaries
| File | Description |
|---|---|
| MarkEditMac/Sources/Settings/EditorSettingsView.swift | Updated as part of this pull request. |
| MarkEditMac/Sources/Main/AppTheme.swift | Updated as part of this pull request. |
| MarkEditMac/Sources/Main/AppResources.swift | Updated as part of this pull request. |
| MarkEditMac/Resources/Localizable.xcstrings | Updated as part of this pull request. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cyanzhong
force-pushed
the
theme-picker
branch
from
September 12, 2026 18:15
9b41079 to
0bf2806
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.