feat(input): scroll-wheel zoom, click binds and safe keybind rules (#285) - #294
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG
…troke for Alt/Win combos (#285) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG
…d wheel capture (#285) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG
#285) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG
…om; version 0.12.0 (#285) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG
#285) - a key bind is swallowed only with its modifiers held (Ctrl+F1 no longer eats F1) - right-click binds with modifiers are no longer cleared by the contextmenu event - raw-input safety net for left/right/middle click binds (lost UP) - stored binds the rules refuse are reset once with a notice in Settings - onboarding saves click-bind modifiers; side buttons keep their modifiers - native Magnifier model passes every wheel notch on - all binds are set before the hooks go live - wheel notch = 0.1 s of holding at zoomInSpeed/zoomOutSpeed; zoomWheelStepPct removed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #285.
What
zoomInSpeedup,zoomOutSpeeddown), so about 10 notches a second feels like holding. No separate step setting.src/keybind_rules.h, mirrored inui/src/lib/keybindRules.js, both tested against one fixture): typing keys alone, Shift/AltGr + a typing key, Windows-reserved combos and Win shortcuts are refused with a reason. Stored binds the rules refuse are reset once, with a notice in Settings.Review
A 4-area review with adversarial verification confirmed 8 findings; all fixed in 8ff5966.
Verified
Notes
🤖 Generated with Claude Code
https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG