chore: ban TypeScript enums via lint rule - #219
Merged
Conversation
ulissesferreira
marked this pull request as ready for review
August 27, 2026 09:34
ulissesferreira
force-pushed
the
chore/ban-enums-lint
branch
from
August 27, 2026 11:35
95768a0 to
68ce5df
Compare
…package script Add an ESLint no-restricted-syntax rule banning TSEnumDeclaration, and convert the MonorepoFiles and Placeholders enums in scripts/create-package to as const objects with derived union types.
ulissesferreira
force-pushed
the
chore/ban-enums-lint
branch
from
August 31, 2026 08:48
68ce5df to
5d399a1
Compare
Battambang
approved these changes
Aug 31, 2026
gabrieledm
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an ESLint
no-restricted-syntaxrule banningTSEnumDeclarationin the shared config, and convert theMonorepoFilesandPlaceholdersenums inscripts/create-packagetoas constobjects with derived union types.Refs: MetaMask/eslint-config#417
Changes
eslint.config.mjs: banTSEnumDeclarationwith the standard MetaMask message (object + type pattern)scripts/create-package/constants.ts: convertMonorepoFilesandPlaceholdersenums toas constobjects + union typesValidation