Skip to content

chore: add NilAway static analysis as pinned go tool - #35

Open
analeis wants to merge 1 commit into
Neon-Genesis-Linux:mainfrom
analeis:main
Open

chore: add NilAway static analysis as pinned go tool#35
analeis wants to merge 1 commit into
Neon-Genesis-Linux:mainfrom
analeis:main

Conversation

@analeis

@analeis analeis commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

this implementation adds NilAway and was rebased onto current upstream main (NGL) to check and satisfy all NilAway cleanups and work done in advance last commit

the recommendation is to keep this tool in a minimum capacity until codebase complexity actually increases.

Reasoning:

  • the tool is known for high cases and chances of false positives where the code can rather be kept cleaner for stylistic and readability reasons, and can sometimes be too conservative by design.
  • It adds extra time and feedback latency between commits. Something that doesn't bother us now, but may not be something we need bogging us down in both CI and in pre-commit-hooks.

Recommended by Simon.

@analeis

analeis commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

Force pushed for cleanliness

Merging the subsequent PRs #35 and #36 may still require rebase and go mod tidy.

@Vuks69

Vuks69 commented Aug 27, 2026

Copy link
Copy Markdown
Member

@Simon-Weij you know more about the tool, if you approve i'll merge

@analeis

analeis commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

Force pushed to rebase for dependency cleanliness since PR #36 was already merged

@analeis

analeis commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto new upstream for maintainer ease.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants