fix(streamer): re-sweep video SETUP on a bounded pace when the rig has no peer yet - #993
Merged
Merged
Conversation
…s no peer yet A rig whose video streamer is still starting answers SETUP with 200 but an empty Transport header. The negotiator fired all URI/Transport forms in under a second and terminally failed with missing-video-peer, never giving the rig a chance. Re-sweep on a bounded pace (3s pauses, at most 3 extra rounds) when at least one 200 arrived without a usable peer, inside the existing 20s request budget. Pure rejections still fail fast, the first SETUP request is byte-identical, and the terminal missing-video-peer code is unchanged after exhaustion. New video-setup-retry log line keeps rounds observable without logging addresses.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
zortos293
added a commit
that referenced
this pull request
Sep 20, 2026
…hen rigs omit Transport (#998) Live YES/ABYA rigs 200 the first video SETUP with an empty Transport header and 400 every further form; ANNOUNCE after such a burst is then rejected, while a single SETUP followed by ANNOUNCE succeeds. Sweeping all forms poisons these sessions, and the old code did exactly that. Stop each sweep at the first 200 (with or without a peer). Peerless 200s still re-issue the same stopped-at form on the bounded #993 pace for late-starting encoders, and terminal exhaustion with a CloudMatch bundle peer proceeds on it (mirroring the official client, which carries on when the server omits transport) instead of failing the seat. Pure rejections still fail fast; the first SETUP request is byte-identical. Also adds redaction-safe DESCRIBE shape logging and an OPENNOW_STREAMER_LOG_FILE sink for the standalone child so headless negotiation failures stay diagnosable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alliance diagnostic showed a rig answering video SETUP with 200 but a zero-byte Transport header (no peer allocated yet), then 400s on the remaining forms. The negotiator fired all 4 URI x 2 Transport forms in ~800ms and terminally failed with \missing-video-peer.
The official Linux client (Bifrost) negotiates through paced progress callbacks (\Waiting for WebRtcTransport ready) and tolerates missing transport (\Disabling ICE since server did not provide transport) instead of failing fast. This mirrors the paced half of that behavior: when at least one 200 arrives without a usable peer, re-sweep with 3s pauses, at most 3 extra rounds, inside the existing 20s request budget.
Changes
ative/opennow-streamer/.../nvst_rtsp.rs: split the sweep out of \setup_video; new bounded retry wrapper (200-without-peer only; pure 400/404/459+ still fail fast; terminal \missing-video-peer\ code unchanged; new \�ideo-setup-retry\ INFO line per round, no addresses logged).
vst_rtsp_setup_tests.rs: harness takes rounds/delay; 3 new tests (peer on retry round succeeds; exhaustion keeps terminal code; pure rejections never retry). All pre-existing tests pass unmodified in behavior (0-retry pinning).
Verification