Skip to content

ci(prow): migrate tikv/tikv release-7.5 jobs to target jenkins - #5155

Open
wuhuizuo wants to merge 1 commit into
mainfrom
phase4/tikv-tikv-release-7.5
Open

ci(prow): migrate tikv/tikv release-7.5 jobs to target jenkins#5155
wuhuizuo wants to merge 1 commit into
mainfrom
phase4/tikv-tikv-release-7.5

Conversation

@wuhuizuo

@wuhuizuo wuhuizuo commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Part of #4964.

Summary

Flip labels.master "1" -> "0" for the jenkins-agent jobs in prow-jobs/tikv/tikv/release-7.5-presubmits.yaml so they are scheduled on the to Jenkins.

Part of #4947 / #4942

Flip labels.master "1" -> "0" for the jenkins-agent jobs in prow-jobs/tikv/tikv/release-7.5-presubmits.yaml so
they are scheduled on the to Jenkins.

Part of #4964
@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dillon-zheng for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary
This PR updates the prow-jobs/tikv/tikv/release-7.5-presubmits.yaml by changing the labels.master value from "1" to "0" for Jenkins agent jobs. This change aims to migrate the scheduling of these jobs from the old Jenkins to the target Jenkins instance. The modifications are minimal and focused, with clear intent and proper context in the description. Overall, the change is straightforward and low risk.


Code Improvements

  • Clarify the meaning of label values

    • File: prow-jobs/tikv/tikv/release-7.5-presubmits.yaml (lines ~12 and ~23)
    • Why: The labels use "master": "0" and "master": "1" as flags for scheduling. Without inline comments or documentation, this is not intuitive for maintainers unfamiliar with this convention.
    • Suggestion: Add a brief comment explaining the purpose of the master label and why "0" means scheduling on the target Jenkins, e.g.:
      labels:
        # master: "0" directs job to target Jenkins; "1" is old Jenkins.
        master: "0"
  • Consistency in comments

    • At line 13 and 24, the comment # need add this. is ungrammatical and unclear.
    • Suggest changing to:
      decorate: false # Needed for Jenkins agent jobs

Best Practices

  • Testing and verification

    • This YAML change impacts CI job scheduling. Ensure that corresponding tests or dry runs validate that jobs are indeed routed to the new Jenkins.
    • If not already done, consider adding or documenting a verification step in the PR or repo docs.
  • Documentation update

    • If there is a central README or documentation that describes the master label or the migration process, update it to reflect this change.
    • This avoids confusion for future maintainers.

No critical issues or broken functionality observed. The change is minimal and isolated, but adding clarifying comments and ensuring documentation/testing coverage will improve maintainability and reduce onboarding friction.

@ti-chi-bot

ti-chi-bot commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Jenkins Migration Verification

Migrating jenkins-agent Prow jobs to the to Jenkins (labels.master: 1 -> 0).

  • tikv/tikv/release-7.5/pull_unit_test
    • status: success
  • tikv/tikv/release-7.5/pull_integration_test
    • status: failed

Summary: success=1 submitted=0 failed=1 infra-fail=0 skipped=0 dry-run=0 total=2

@ti-chi-bot ti-chi-bot Bot added the size/XS label Sep 4, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

@wuhuizuo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify-jenkins-migration c614499 link true /test pull-verify-jenkins-migration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

wuhuizuo added a commit that referenced this pull request Sep 4, 2026
Split from #5155: jobs verified SUCCESS on the to Jenkins in
pull-verify-jenkins-migration runid 2095812213846577152. Flip their labels.master.

Part of #4964
wuhuizuo added a commit that referenced this pull request Sep 4, 2026
…ns (#5166)

Split from #5155 — only the jobs that verified **SUCCESS** on the to
Jenkins (verify runid 2095812213846577152):
- `pull_unit_test`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants