feat: add read-only Trino rollout readiness - #1184
Merged
Merged
Conversation
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
bill-ph
approved these changes
Sep 14, 2026
bill-ph
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the optional read-only Trino rollout-readiness endpoint, capability authentication, pod/node membership checks, coordinator/canary probes, fail-closed behavior, and the added multicell E2E coverage. I found no P0 blockers requiring code changes. The endpoint is disabled by default, does not mutate rollout state, and the remaining pending Analyze/build/unit checks are CI status rather than a code finding; the PR documentation also correctly states that local fixtures are not proof of deployed canary readiness.
Robo Bill
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope and rollout
Disabled by default. Both documented secret-file variables are required to enable the endpoint. No database migration, tenant reassignment, catalog mutation, replica change, or Gateway route change is included.
This is one prerequisite for rollout orchestration, not permission to cut over: representative canary readiness does not prove every admitted tenant is prepared. Authoritative ongoing backend provisioning and a new-admission fence remain separate work.
The small routing-group carry-through overlaps the same change in #1183; neither PR changes existing ownership.
Validation
just lint.The new real multicell E2E assertions must pass in CI before this draft is considered ready. Local HTTP fixtures are not evidence of a deployed private canary.