fix(prompts): support unlabeled batch fetch in get_all - #966
Merged
Merged
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "fix(prompts): support unlabeled batch fe..." | Re-trigger Greptile |
Contributor
posthog-python Compliance ReportDate: 2026-09-16 19:07:42 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
This was referenced Sep 16, 2026
marandaneto
approved these changes
Sep 17, 2026
marandaneto
left a comment
Member
There was a problem hiding this comment.
The code looks good; no qualifying findings. Verdict: correct.
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
get_allrequires a label, so there is no way to batch-fetch the latest version of every prompt. Passinglabel=Noneanyway urlencodes to the literal stringlabel=None, and the server filters by a label named "None", returning an empty result. Reported by a customer.Changes
labelonget_allis now optional. Without it, the request omits thelabelparam and returns the latest version of every prompt, matching plainget(name).get(name)reads, so those calls become cache hits.How did you test this code?
Added one test to
TestPromptsGetAll: the unlabeled fetch must omit thelabelparam from the URL, accept rows without labels, and seed the unlabeledget()cache. All 78 prompt tests pass locally.