fix: declare hms in Imports (required by RSQLite, not declared by it) - #22
Open
eliotmcintire wants to merge 1 commit into
Open
fix: declare hms in Imports (required by RSQLite, not declared by it)#22eliotmcintire wants to merge 1 commit into
eliotmcintire wants to merge 1 commit into
Conversation
The no-suggests CI leg fails with:
* checking examples ... ERROR
Error in check_suggested("hms", "dbConnect") :
sqlite_connect_db() calls RSQLite::dbConnect(extended_types = TRUE), which
makes RSQLite return DATETIME columns as hms/POSIXct and therefore requires the
hms package at runtime. RSQLite declares hms in its Suggests, not Imports, so
nothing in the dependency graph guarantees it is installed.
That is invisible in a normal check -- Suggests are installed anyway -- but
fails under _R_CHECK_DEPENDS_ONLY_=true, which builds a library containing only
this package's Depends/Imports/LinkingTo.
The requirement is real and RSQLite does not state it correctly, so climateData
declares it. Rationale recorded next to the dbConnect call rather than in
DESCRIPTION, which is DCF and cannot carry comments.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012DVjmY3im9Xak7tXLSMGCa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the one failing leg on #20 —
ubuntu-latest (release, nosuggests):Why
sqlite_connect_db()calls:extended_types = TRUEmakes RSQLite return DATETIME columns ashms/POSIXct, which requireshmsat runtime. But RSQLite declareshmsin its Suggests, not Imports — so nothing in the dependency graph guarantees it is installed.This is invisible in a normal check, where Suggests are present anyway. It fails under
_R_CHECK_DEPENDS_ONLY_=true(the no-suggests leg), which builds a library containing only this package's Depends/Imports/LinkingTo.The requirement is real and RSQLite does not state it correctly, so climateData declares it directly.
Where the rationale lives
DESCRIPTIONis DCF and cannot carry comments, so the explanation sits next to thedbConnectcall inR/ClimateNA_createTiles.R— where someone changingextended_typeswill actually see it.Note
The no-suggests leg is new to this repo; it arrived with the migration to the org reusable workflow and found this on its first run. The bug was always there — nothing was testing for it.
🤖 Generated with Claude Code
https://claude.ai/code/session_012DVjmY3im9Xak7tXLSMGCa