Skip to content

fix: declare hms in Imports (required by RSQLite, not declared by it) #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eliotmcintire wants to merge 1 commit into
base: development
Choose a base branch
from
+13 −1
Open

fix: declare hms in Imports (required by RSQLite, not declared by it) #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ Imports:
fs,
future.apply,
glue,
hms,
methods,
parallel,
parallelly,
Expand Down
13 changes: 12 additions & 1 deletion R/ClimateNA_createTiles.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,22 @@ ClimateNA_path <- function(dataPath, tile = NULL, type = NULL, msy = NULL, gcm =
sqlite_connect_db <- function(dbfile) {
firstRun <- file.exists(dbfile)

## `extended_types = TRUE` makes RSQLite return DATETIME columns as hms /
## POSIXct, which requires the `hms` package AT RUNTIME. RSQLite declares hms
## only in its Suggests, not Imports, so nothing in the dependency graph
## guarantees it is installed -- `RSQLite::dbConnect(extended_types = TRUE)`
## then fails with `check_suggested("hms", "dbConnect")`.
##
## That is invisible in a normal check, where Suggests are present anyway, but
## fails under _R_CHECK_DEPENDS_ONLY_=true (the no-suggests CI leg), which
## builds a library containing only this package's Depends/Imports/LinkingTo.
## climateData therefore declares hms in its own Imports: the requirement is
## real and RSQLite does not state it correctly.
db <- RSQLite::dbConnect(
drv = RSQLite::SQLite(),
dbname = dbfile,
synchronous = "normal",
extended_types = TRUE ## for DATETIME
extended_types = TRUE ## for DATETIME -- see note above re: hms
)

if (isTRUE(firstRun)) {
Expand Down
Loading