Skip to content

Fix WorldScape3D support for region size 4096x4096 - #1425

Open
OldDev78 wants to merge 1 commit into
Redot-Engine:masterfrom
OldDev78:fix-region-size-4096-support
Open

OldDev78 wants to merge 1 commit into
Redot-Engine:masterfrom
OldDev78:fix-region-size-4096-support

Conversation

@OldDev78

@OldDev78 OldDev78 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

When the Terrain3D integration was ported from ReX to Redot, the region size limit was bumped up from 2048x2048 to 4096x4096. However, not all the code was updated accordingly, which caused some instability issues, including crash candidates with some tools.

This changeset finally enables use of large region sizes.

Summary by CodeRabbit

  • New Features
    • Increased the maximum supported 3D world region size from 2048 to 4096.
    • Region sizes from 64 through 4096 are now accepted when using valid power-of-two dimensions.
  • Bug Fixes
    • Updated size validation messaging to accurately reflect the expanded supported range.

@OldDev78
OldDev78 requested review from a team September 15, 2026 20:16
@OldDev78 OldDev78 changed the title Fix support for region size 4096x4096 Fix WorldScape3D support for region size 4096x4096 Sep 15, 2026
@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 6ac4a060-150c-4728-ab7a-4226825310c1

📥 Commits

Reviewing files that changed from the base of the PR and between 2ab24bc and 18aaa7c.

📒 Files selected for processing (3)
  • modules/worldscape_3d/worldscape_3d_region.cpp
  • modules/worldscape_3d/worldscape_3d_region.h
  • modules/worldscape_3d/worldscape_3d_util.h

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


Walkthrough

The WorldScape 3D region size limit increases from 2048 to 4096. The 64 minimum and power-of-two requirement remain unchanged. The validation error message reflects the new maximum.

Changes

WorldScape region size

Layer / File(s) Summary
Align region size limits
modules/worldscape_3d/worldscape_3d_util.h, modules/worldscape_3d/worldscape_3d_region.h, modules/worldscape_3d/worldscape_3d_region.cpp
Region size validation and clamping now allow values through 4096. The map-size error message changes to Image size out of bounds (64-4096).

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: arctis-fireblight, decryptedchaos

Merge Risk: ⚪ Minimal · up to 18aaa

The region-size limit is updated consistently across the affected WorldScape paths, with no concrete merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: support for 4096x4096 WorldScape3D regions.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Open

Development

Successfully merging this pull request may close these issues.

1 participant