Skip to content

Fix WorldScape3D support for region size 4096x4096 #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Arctis-Fireblight merged 1 commit into from
Sep 21, 2026
+4 −4
Merged

Fix WorldScape3D support for region size 4096x4096 #1425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/worldscape_3d/worldscape_3d_region.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,8 @@ bool WorldScape3DRegion::validate_map_size(const Ref<Image> &p_map) const {
LOG(ERROR, "Image dimensions are not a power of 2: ", region_sizev);
return false;
}
if (region_sizev.x < 64 || region_sizev.y > 2048) {
LOG(ERROR, "Image size out of bounds (64-2048): ", region_sizev);
if (region_sizev.x < 64 || region_sizev.y > 4096) {
LOG(ERROR, "Image size out of bounds (64-4096): ", region_sizev);
return false;
}
if (_region_size == 0) {
Expand Down
2 changes: 1 addition & 1 deletion modules/worldscape_3d/worldscape_3d_region.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class WorldScape3DRegion : public Resource {

void set_version(const real_t p_version);
real_t get_version() const { return _version; }
void set_region_size(const int p_region_size) { _region_size = CLAMP(p_region_size, 64, 2048); }
void set_region_size(const int p_region_size) { _region_size = CLAMP(p_region_size, 64, 4096); }
int get_region_size() const { return _region_size; }

// Maps
Expand Down
2 changes: 1 addition & 1 deletion modules/worldscape_3d/worldscape_3d_util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ constexpr Vector3 v2v3(const Vector2 p_v2) {
///////////////////////////

constexpr bool is_valid_region_size(int value) {
return value >= 64 && value <= 2048 && is_power_of_2(value);
return value >= 64 && value <= 4096 && is_power_of_2(value);
}

// Integer round to multiples
Expand Down
Loading