gccrs: add unused comparisons lint - #4626
Closed
lucasly-ba wants to merge 1 commit into
Closed
lucasly-ba wants to merge 1 commit into
lucasly-ba wants to merge 1 commit into
Conversation
lucasly-ba
force-pushed
the
unused-comparisons
branch
3 times, most recently
from
July 6, 2026 12:03
a0a3d0f to
b8def32
Compare
lucasly-ba
force-pushed
the
unused-comparisons
branch
2 times, most recently
from
July 8, 2026 22:30
97217e2 to
b707bc6
Compare
gcc/rust/ChangeLog: * checks/lints/unused/rust-unused-checker.cc (UnusedChecker::visit): New. * checks/lints/unused/rust-unused-checker.h (UnusedChecker::visit): New. * rust-lang.cc (grs_langhook_init_options_struct): Enable warn_type_limits. gcc/testsuite/ChangeLog: * rust/compile/unused-comparisons_0.rs: New test. Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
lucasly-ba
force-pushed
the
unused-comparisons
branch
from
July 9, 2026 13:35
b707bc6 to
b4c3d57
Compare
Contributor
Author
P-E-P
self-requested a review
July 16, 2026 17:55
P-E-P
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds the unused comparisons lint, which warns on comparisons that are always true or false due to the type limits of an unsigned integer.
gcc/testsuite/ChangeLog: