Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions src/components/shared/Dialogs/ComponentDetailsDialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import { ComponentFavoriteToggle } from "../FavoriteComponentToggle";
import { InfoBox } from "../InfoBox";
import { PublishComponent } from "../ManageComponent/PublishComponent";
import { PublishedComponentDetails } from "../ManageComponent/PublishedComponentDetails";
import { useFlagValue } from "../Settings/useFlags";
import { withSuspenseWrapper } from "../SuspenseWrapper";
import { TaskDetails, TaskImplementation, TaskIO } from "../TaskDetails";
import TaskActions from "../TaskDetails/Actions";
Expand Down Expand Up @@ -65,10 +64,6 @@ const ComponentDetailsDialogContentSkeleton = () => {

const ComponentDetailsDialogContent = withSuspenseWrapper(
({ component, displayName, readOnly }: ComponentDetailsProps) => {
const remoteComponentLibrarySearchEnabled = useFlagValue(
"remote-component-library-search",
);

const componentRef = useHydrateComponentReference(component);

if (!componentRef) {
Expand All @@ -81,8 +76,7 @@ const ComponentDetailsDialogContent = withSuspenseWrapper(

const componentSpec = componentRef.spec;

const hasPublishSection =
remoteComponentLibrarySearchEnabled && component.owned;
const hasPublishSection = component.owned;

return (
<>
Expand Down Expand Up @@ -124,12 +118,10 @@ const ComponentDetailsDialogContent = withSuspenseWrapper(

<div className="overflow-auto h-[40vh]">
<TabsContent value="details">
{remoteComponentLibrarySearchEnabled && (
<PublishedComponentDetails
component={componentRef}
readOnly={readOnly}
/>
)}
<PublishedComponentDetails
component={componentRef}
readOnly={readOnly}
/>

<TaskDetails componentRef={componentRef} />
<TaskActions
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ const createMockComponentLibraryContext = (
isLoading: false,
error: null,
existingComponentLibraries: undefined,
searchResult: null,
searchComponentLibrary: vi.fn(),
addToComponentLibrary: vi.fn(),
removeFromComponentLibrary: vi.fn(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ import { UpgradeNodePopover } from "./UpgradeNodePopover";

const TaskNodeCard = () => {
const navigate = useNavigate();
const isRemoteComponentLibrarySearchEnabled = useFlagValue(
"remote-component-library-search",
);
const inputAggregatorEnabled = useFlagValue("input-aggregator");

const { registerNode } = useNodesOverlay();
Expand Down Expand Up @@ -260,16 +257,12 @@ const TaskNodeCard = () => {
)}
</BlockStack>

{isRemoteComponentLibrarySearchEnabled ? (
<PublishedComponentBadge
componentRef={taskSpec.componentRef}
readOnly={readOnly}
>
{digestMarkup}
</PublishedComponentBadge>
) : (
digestMarkup
)}
<PublishedComponentBadge
componentRef={taskSpec.componentRef}
readOnly={readOnly}
>
{digestMarkup}
</PublishedComponentBadge>
</CardHeader>
<CardContent className="p-2 flex flex-col gap-2">
{isSubgraphNode && subgraphExecutionStats && (
Expand Down Expand Up @@ -298,7 +291,7 @@ const TaskNodeCard = () => {
onBackgroundClick={handleOutputSectionClick}
/>
</div>
{isRemoteComponentLibrarySearchEnabled && updateOverlayDialogOpen ? (
{updateOverlayDialogOpen ? (
<UpgradeNodePopover
currentNode={taskNode}
onOpenChange={closeOverlayPopover}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { useCallback, useMemo, useRef } from "react";
import { ComponentDetailsDialog } from "@/components/shared/Dialogs";
import { ComponentFavoriteToggle } from "@/components/shared/FavoriteComponentToggle";
import { useOutdatedComponents } from "@/components/shared/ManageComponent/hooks/useOutdatedComponents";
import { useFlagValue } from "@/components/shared/Settings/useFlags";
import { withSuspenseWrapper } from "@/components/shared/SuspenseWrapper";
import { Icon } from "@/components/ui/icon";
import { InlineStack } from "@/components/ui/layout";
Expand Down Expand Up @@ -105,12 +104,6 @@ const ComponentMarkup = ({
showOutdatedBadge = true,
source,
}: ComponentMarkupProps) => {
const isRemoteComponentLibrarySearchEnabled = useFlagValue(
"remote-component-library-search",
);
const shouldShowOutdatedBadge =
isRemoteComponentLibrarySearchEnabled && showOutdatedBadge;

const popoverRef = useRef<ComponentHoverPopoverHandle>(null);

// TODO: respect selected node as a starting point
Expand Down Expand Up @@ -252,7 +245,7 @@ const ComponentMarkup = ({
wrap="nowrap"
blockAlign="start"
>
{shouldShowOutdatedBadge ? (
{showOutdatedBadge ? (
<ComponentIcon
name={iconName}
className={iconClass}
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

Loading
Loading