Conversation
|
Thanks for picking this up. #901 also fixes #893, and it includes both changes here: While sweeping for #893 we found the same bare load in about 40 more places, and #901 fixes them too:
Each case has a test that fails on Both PRs change the same lines in |
|
No findings. The PR description documents sufficient testing, including a representative real-CLI |
jeff-r2026
left a comment
There was a problem hiding this comment.
Please resolve the conflicts
|
Thanks for the review. #901 has now merged and includes both changes in this PR: |
Summary
--dry-runtoautoDetectInitfrommcp inject, keeping legacy-role migration and legacy project-partition adoption in memory.mcp listwithdryRun: truebecause it is read-only.Fixes #893.
Verification
npx vitest run src/__tests__/dry-run-load-path.test.ts src/__tests__/mcp-cmd.test.ts— 30 tests passed.npx tsc --noEmit— passed.npm run lint— passed.npm run build— passed.node dist/index.js mcp inject --dry-runwith a legacy role-less user config printed the migration preview and leftconfig.yamlunchanged.The full Vitest suite was attempted on Windows but did not complete cleanly because unrelated tests hit platform-specific permission/shell expectations and temporary-path
EPERM/timeouts. The targeted MCP and dry-run suites pass.