feat(storage): Implement ObjectStoreStorage::S3 (Supersedes #2257) - #3165
Open
Sruhvx-jpg wants to merge 4 commits into
Open
feat(storage): Implement ObjectStoreStorage::S3 (Supersedes #2257)#3165Sruhvx-jpg wants to merge 4 commits into
Sruhvx-jpg wants to merge 4 commits into
Conversation
…oncurrent deletes - Hoist `object_store` 0.13 to workspace dependencies to align with DataFusion. - Support `s3n://` scheme alongside `s3://` and `s3a://` in `parse_s3_url`. - Optimize `delete_stream` with `try_for_each_concurrent` instead of sequential loop. - Add unit tests for `s3n://` URL parsing and FileIO/Storage serialization roundtrips. - Wire crate workspace lints and publish flag.
Author
|
Apologies for any notification noise from the extra PR earlier. Everything has been cleanly unified into this PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Implement
ObjectStoreStorage::S3backed by Apache Arrow'sobject_storecrate. Originally drafted by @CTTY in #2257 and revived onto current main:object_store0.13 to workspace dependencies (aligned with DataFusion).s3://,s3a://, ands3n://URL schemes with empty bucket validation.WriteMultipart::put(bs)instead of slice copying.delete_streamusingtry_for_each_concurrent.Are these changes tested?
Yes, all 12 unit tests covering S3 URL parsing, empty bucket checks, store cache reuse, and
FileIO/StorageFactoryserialization roundtrips passing (cargo test -p iceberg-storage-object_store).