-
Notifications
You must be signed in to change notification settings - Fork 582
feat(storage): Implement ObjectStoreStorage::S3 (Supersedes #2257) #3165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sruhvx-jpg
wants to merge
18
commits into
apache:main
Choose a base branch
from
Sruhvx-jpg:revive-os-s3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
76009ee
Implement Storage for object-store
CTTY 5e18076
feat(storage): modernize object_store backend, support s3n, and add c…
Sruhvx-jpg b22898d
feat(storage): zero-copy writes and empty bucket validation in object…
Sruhvx-jpg 6457dbd
chore: add public-api.txt, format toml with taplo, and fix doc links
Sruhvx-jpg ed8a391
fix(ci): update rustls to 0.23.45, unpublish object_store, and fix pu…
Sruhvx-jpg 2fbde2a
Merge branch 'main' into revive-os-s3
Sruhvx-jpg fa5ff4b
fix(storage): S3 KMS default key, URL percent-decode, batch delete_pr…
Sruhvx-jpg e2f101a
Merge upstream main into revive-os-s3
Sruhvx-jpg eb7387f
chore: fix cargo fmt formatting and match Swatinem/rust-cache in work…
Sruhvx-jpg 52b11c0
test: use existing bucket1 with percent-encoding in file_io_s3_test
Sruhvx-jpg 08e2338
test(s3): handle MinIO 501 on KMS integration tests
Sruhvx-jpg 956743f
test(s3): handle MinIO 501 on SSE-S3 AES256 integration test
Sruhvx-jpg e951cca
Merge branch 'main' into revive-os-s3
Sruhvx-jpg d6d64b0
fix(storage): multipart upload lifecycle aborts, error kind mappings,…
Sruhvx-jpg bc57b42
Merge branch 'main' into revive-os-s3
Sruhvx-jpg cc6edad
fix(storage): bound multipart upload concurrency and fail-fast during…
Sruhvx-jpg 4b74547
Merge branch 'main' into revive-os-s3
Sruhvx-jpg 67f3677
fix(storage): bound multipart upload concurrency and fail-fast during…
Sruhvx-jpg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| [package] | ||
| edition = { workspace = true } | ||
| license = { workspace = true } | ||
| name = "iceberg-storage-object_store" | ||
| publish = false | ||
| repository = { workspace = true } | ||
| version = { workspace = true } | ||
|
|
||
| categories = ["database"] | ||
| description = "Apache Iceberg object_store storage implementation" | ||
| keywords = ["iceberg", "object-store", "storage", "s3"] | ||
|
|
||
| [features] | ||
| default = ["object_store-s3"] | ||
| object_store-s3 = ["object_store/aws"] | ||
|
|
||
| [dependencies] | ||
| async-trait = { workspace = true } | ||
| bytes = { workspace = true } | ||
| dashmap = { workspace = true } | ||
| futures = { workspace = true } | ||
| iceberg = { workspace = true } | ||
| object_store = { workspace = true } | ||
| percent-encoding = { workspace = true } | ||
| serde = { workspace = true, features = ["derive"] } | ||
| tokio = { workspace = true } | ||
| tracing = { workspace = true } | ||
| typetag = { workspace = true } | ||
| url = { workspace = true } | ||
|
|
||
| [dev-dependencies] | ||
| iceberg_test_utils = { path = "../../test_utils", features = ["tests"] } | ||
| serde_json = { workspace = true } | ||
| tokio = { workspace = true, features = ["macros", "rt-multi-thread"] } | ||
|
|
||
| [lints] | ||
| workspace = true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../LICENSE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../NOTICE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| pub mod iceberg_storage_object_store | ||
| pub enum iceberg_storage_object_store::ObjectStoreStorage | ||
| pub iceberg_storage_object_store::ObjectStoreStorage::S3(iceberg_storage_object_store::S3Storage) | ||
| impl core::clone::Clone for iceberg_storage_object_store::ObjectStoreStorage | ||
| pub fn iceberg_storage_object_store::ObjectStoreStorage::clone(&self) -> iceberg_storage_object_store::ObjectStoreStorage | ||
| impl core::fmt::Debug for iceberg_storage_object_store::ObjectStoreStorage | ||
| pub fn iceberg_storage_object_store::ObjectStoreStorage::fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result | ||
| impl iceberg::io::storage::Storage for iceberg_storage_object_store::ObjectStoreStorage | ||
| pub fn iceberg_storage_object_store::ObjectStoreStorage::delete<'life0, 'life1, 'async_trait>(&'life0 self, path: &'life1 str) -> core::pin::Pin<alloc::boxed::Box<(dyn core::future::future::Future<Output = iceberg::error::Result<()>> + core::marker::Send + 'async_trait)>> where Self: 'async_trait, 'life0: 'async_trait, 'life1: 'async_trait | ||
| pub fn iceberg_storage_object_store::ObjectStoreStorage::delete_prefix<'life0, 'life1, 'async_trait>(&'life0 self, path: &'life1 str) -> core::pin::Pin<alloc::boxed::Box<(dyn core::future::future::Future<Output = iceberg::error::Result<()>> + core::marker::Send + 'async_trait)>> where Self: 'async_trait, 'life0: 'async_trait, 'life1: 'async_trait | ||
| pub fn iceberg_storage_object_store::ObjectStoreStorage::delete_stream<'life0, 'async_trait>(&'life0 self, paths: futures_core::stream::BoxStream<'static, alloc::string::String>) -> core::pin::Pin<alloc::boxed::Box<(dyn core::future::future::Future<Output = iceberg::error::Result<()>> + core::marker::Send + 'async_trait)>> where Self: 'async_trait, 'life0: 'async_trait | ||
| pub fn iceberg_storage_object_store::ObjectStoreStorage::exists<'life0, 'life1, 'async_trait>(&'life0 self, path: &'life1 str) -> core::pin::Pin<alloc::boxed::Box<(dyn core::future::future::Future<Output = iceberg::error::Result<bool>> + core::marker::Send + 'async_trait)>> where Self: 'async_trait, 'life0: 'async_trait, 'life1: 'async_trait | ||
| pub fn iceberg_storage_object_store::ObjectStoreStorage::metadata<'life0, 'life1, 'async_trait>(&'life0 self, path: &'life1 str) -> core::pin::Pin<alloc::boxed::Box<(dyn core::future::future::Future<Output = iceberg::error::Result<iceberg::io::file_io::FileMetadata>> + core::marker::Send + 'async_trait)>> where Self: 'async_trait, 'life0: 'async_trait, 'life1: 'async_trait | ||
| pub fn iceberg_storage_object_store::ObjectStoreStorage::new_input(&self, path: &str) -> iceberg::error::Result<iceberg::io::file_io::InputFile> | ||
| pub fn iceberg_storage_object_store::ObjectStoreStorage::new_output(&self, path: &str) -> iceberg::error::Result<iceberg::io::file_io::OutputFile> | ||
| pub fn iceberg_storage_object_store::ObjectStoreStorage::read<'life0, 'life1, 'async_trait>(&'life0 self, path: &'life1 str) -> core::pin::Pin<alloc::boxed::Box<(dyn core::future::future::Future<Output = iceberg::error::Result<bytes::bytes::Bytes>> + core::marker::Send + 'async_trait)>> where Self: 'async_trait, 'life0: 'async_trait, 'life1: 'async_trait | ||
| pub fn iceberg_storage_object_store::ObjectStoreStorage::reader<'life0, 'life1, 'async_trait>(&'life0 self, path: &'life1 str) -> core::pin::Pin<alloc::boxed::Box<(dyn core::future::future::Future<Output = iceberg::error::Result<alloc::boxed::Box<dyn iceberg::io::file_io::FileRead>>> + core::marker::Send + 'async_trait)>> where Self: 'async_trait, 'life0: 'async_trait, 'life1: 'async_trait | ||
| pub fn iceberg_storage_object_store::ObjectStoreStorage::write<'life0, 'life1, 'async_trait>(&'life0 self, path: &'life1 str, bs: bytes::bytes::Bytes) -> core::pin::Pin<alloc::boxed::Box<(dyn core::future::future::Future<Output = iceberg::error::Result<()>> + core::marker::Send + 'async_trait)>> where Self: 'async_trait, 'life0: 'async_trait, 'life1: 'async_trait | ||
| pub fn iceberg_storage_object_store::ObjectStoreStorage::writer<'life0, 'life1, 'async_trait>(&'life0 self, path: &'life1 str) -> core::pin::Pin<alloc::boxed::Box<(dyn core::future::future::Future<Output = iceberg::error::Result<alloc::boxed::Box<dyn iceberg::io::file_io::FileWrite>>> + core::marker::Send + 'async_trait)>> where Self: 'async_trait, 'life0: 'async_trait, 'life1: 'async_trait | ||
| impl serde_core::ser::Serialize for iceberg_storage_object_store::ObjectStoreStorage | ||
| pub fn iceberg_storage_object_store::ObjectStoreStorage::serialize<__S>(&self, __serializer: __S) -> core::result::Result<<__S as serde_core::ser::Serializer>::Ok, <__S as serde_core::ser::Serializer>::Error> where __S: serde_core::ser::Serializer | ||
| impl<'de> serde_core::de::Deserialize<'de> for iceberg_storage_object_store::ObjectStoreStorage | ||
| pub fn iceberg_storage_object_store::ObjectStoreStorage::deserialize<__D>(__deserializer: __D) -> core::result::Result<Self, <__D as serde_core::de::Deserializer>::Error> where __D: serde_core::de::Deserializer<'de> | ||
| pub enum iceberg_storage_object_store::ObjectStoreStorageFactory | ||
| pub iceberg_storage_object_store::ObjectStoreStorageFactory::S3 | ||
| impl core::clone::Clone for iceberg_storage_object_store::ObjectStoreStorageFactory | ||
| pub fn iceberg_storage_object_store::ObjectStoreStorageFactory::clone(&self) -> iceberg_storage_object_store::ObjectStoreStorageFactory | ||
| impl core::fmt::Debug for iceberg_storage_object_store::ObjectStoreStorageFactory | ||
| pub fn iceberg_storage_object_store::ObjectStoreStorageFactory::fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result | ||
| impl iceberg::io::storage::StorageFactory for iceberg_storage_object_store::ObjectStoreStorageFactory | ||
| pub fn iceberg_storage_object_store::ObjectStoreStorageFactory::build(&self, config: &iceberg::io::storage::config::StorageConfig) -> iceberg::error::Result<alloc::sync::Arc<dyn iceberg::io::storage::Storage>> | ||
| impl serde_core::ser::Serialize for iceberg_storage_object_store::ObjectStoreStorageFactory | ||
| pub fn iceberg_storage_object_store::ObjectStoreStorageFactory::serialize<__S>(&self, __serializer: __S) -> core::result::Result<<__S as serde_core::ser::Serializer>::Ok, <__S as serde_core::ser::Serializer>::Error> where __S: serde_core::ser::Serializer | ||
| impl<'de> serde_core::de::Deserialize<'de> for iceberg_storage_object_store::ObjectStoreStorageFactory | ||
| pub fn iceberg_storage_object_store::ObjectStoreStorageFactory::deserialize<__D>(__deserializer: __D) -> core::result::Result<Self, <__D as serde_core::de::Deserializer>::Error> where __D: serde_core::de::Deserializer<'de> | ||
| pub struct iceberg_storage_object_store::S3Storage | ||
| impl core::clone::Clone for iceberg_storage_object_store::S3Storage | ||
| pub fn iceberg_storage_object_store::S3Storage::clone(&self) -> iceberg_storage_object_store::S3Storage | ||
| impl core::fmt::Debug for iceberg_storage_object_store::S3Storage | ||
| pub fn iceberg_storage_object_store::S3Storage::fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result | ||
| impl serde_core::ser::Serialize for iceberg_storage_object_store::S3Storage | ||
| pub fn iceberg_storage_object_store::S3Storage::serialize<__S>(&self, __serializer: __S) -> core::result::Result<<__S as serde_core::ser::Serializer>::Ok, <__S as serde_core::ser::Serializer>::Error> where __S: serde_core::ser::Serializer | ||
| impl<'de> serde_core::de::Deserialize<'de> for iceberg_storage_object_store::S3Storage | ||
| pub fn iceberg_storage_object_store::S3Storage::deserialize<__D>(__deserializer: __D) -> core::result::Result<Self, <__D as serde_core::de::Deserializer>::Error> where __D: serde_core::de::Deserializer<'de> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.