fix: preserve review section state and align shared UI contracts - #1825
Draft
Jacky-Pham wants to merge 2 commits into
Draft
Jacky-Pham wants to merge 2 commits into
Jacky-Pham wants to merge 2 commits into
Conversation
Collaborator
|
Temporary Url for review: https://strr-strata-hotel-dev--pr-1825-cqa00sgu.web.app |
Collaborator
|
Temporary Url for review: https://strr-platform-dev--pr-1825-71ujlufk.web.app |
Collaborator
|
Temporary Url for review: https://strr-examiner-dev--pr-1825-tjn9olcx.web.app |
Collaborator
|
Temporary Url for review: https://strr-hosts-dev--pr-1825-fp1tqsdk.web.app |
|
Collaborator
|
Temporary Url for review: https://strr-strata-hotel-dev--pr-1825-cqa00sgu.web.app |
Collaborator
|
Temporary Url for review: https://strr-examiner-dev--pr-1825-tjn9olcx.web.app |
Collaborator
|
Temporary Url for review: https://strr-platform-dev--pr-1825-71ujlufk.web.app |
Collaborator
|
Temporary Url for review: https://strr-hosts-dev--pr-1825-fp1tqsdk.web.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review sections allow items without titles, but their Vue keys previously became
NaN. A validation re-render discarded slotted input state and duplicated rendered content. Use a defined title fallback in the key; the new regression exercises both untitled sections and the titled control with the real section and info-box components.Align the remaining shared contracts with existing behavior: retain literal address keys, give the STRR help URL its documented default, accept API payment-status strings in the pending-state check, remove an unused TypeScript suppression, and read the date duration as a scalar without changing invalid-date behavior.
Patch Nuxt UI 2.22.3's alert declaration to accept
closeButton: null, which the runtime already supports for non-dismissible alerts. Each independently installed frontend includes the same declaration-only patch. All resolved dependency versions and the alert runtime file are unchanged. Pin the base package to the same pnpm 10.21.0 used by the other apps; its previous pnpm 9 CI default rejects the patch metadata.Validation on Node 24/pnpm 10.21:
classfield after accepting null.Combined-source CI passes all five frontend lint/test/build jobs and 1,044 tests with the earlier fixes applied. Combined strict checks improve from 362 to 289 diagnostics (base 39, Host 78, Platform 48, Strata 61, Examiner 63); the base package's own source is clean, but dependency and consumer errors remain. This run used pnpm 10.21.0 explicitly; the sole subsequent change is the base package-manager pin to that same version.
The initial standard base CI failed because pnpm 9 rejected the patch metadata. The frozen base install passes with the corrected package-manager pin. All final checks on
9016aadfare complete: the five standard frontend lint/test/build workflows pass (718 tests), as do CodeQL and all four Cloud Build checks. The unused npm jobs are intentionally skipped; the unused base Cloud Build check is neutral.