fix: close Strata upload panel when its application changes - #1842
Draft
Jacky-Pham wants to merge 1 commit into
Draft
Jacky-Pham wants to merge 1 commit into
Jacky-Pham wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Strata permit store resets or reloads an application while its dashboard upload panel is open, the page dereferences the cleared application and raises a render error. The open-panel state also survives the reload, so the panel appears again without a new request to open it.
Close the panel synchronously when its application number changes and mount the uploader only while that number is available. This disposes the checked-out shared queue before it can continue after a record change.
Validation: eight actual-page/shared-queue cases (three baseline lifecycle failures, five passing upload controls); all 92 local Strata tests and lint pass. The tests use real Pinia stores/loaders with controlled API responses, file-selection events, and upload completion. They prove component behavior; deployed navigation and backend uploads are outside these tests. Strict checks add no diagnostics (combined Strata: 7 default / 2 configured). Strata CI passes lint, 92 tests, and build at the PR head. Combined CI passes all five frontend lint/test/build jobs with 1,223 tests at
8f518420.Stacked on #1841. No merge or deployment.