Skip to content

Ignore deleted headerless diff paths - #272

Merged
chailandau merged 1 commit into
mainfrom
chai/ignore-deleted-diff-paths
Aug 21, 2026
Merged

Ignore deleted headerless diff paths#272
chailandau merged 1 commit into
mainfrom
chai/ignore-deleted-diff-paths

Conversation

@chailandau

Copy link
Copy Markdown
Collaborator

Why

Headerless unified diffs represent deleted files with +++ /dev/null. The review parser strips the leading slash first, so it can incorrectly treat dev/null as a touched material path.

What

  • Ignore /dev/null destinations before normalizing headerless diff paths
  • Cover deleted and newly added files with focused parser tests
  • Add a patch changeset for the public package

Risk Assessment

Low. The change only affects fallback parsing for unified diffs without diff --git headers.

Generated with Goose

@chailandau
chailandau marked this pull request as ready for review August 21, 2026 20:14
@chailandau
chailandau merged commit 511c9ee into main Aug 21, 2026
4 checks passed
@chailandau
chailandau deleted the chai/ignore-deleted-diff-paths branch August 21, 2026 20:14
@github-actions github-actions Bot mentioned this pull request Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant