Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/calm-diffs-rest.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@design-intelligence/ghost": patch
---

Prevent review packets from treating deleted files as a `dev/null` material.
9 changes: 6 additions & 3 deletions packages/ghost/src/review/diff.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,13 @@ export function parseTouchedFiles(diffText: string): TouchedFile[] {
current = { path: gitHeader[2], start: i };
continue;
}
const plusPlus = line.match(/^\+\+\+ b?\/?(.+)$/);
const plusPlus = line.match(/^\+\+\+ (.+)$/);
if (plusPlus && current === null) {
const p = plusPlus[1].trim();
if (p !== "/dev/null") current = { path: p, start: i };
const destination = plusPlus[1].trim();
if (destination !== "/dev/null") {
const path = destination.replace(/^b\//, "");
current = { path, start: i };
}
}
}
flush(lines.length);
Expand Down
28 changes: 28 additions & 0 deletions packages/ghost/test/review-diff.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import { describe, expect, it } from "vitest";
import { parseTouchedFiles } from "../src/review/diff.js";

describe("parseTouchedFiles", () => {
it("ignores deleted files in headerless unified diffs", () => {
const diff = [
"--- a/brand/logo.svg",
"+++ /dev/null",
"@@ -1 +0,0 @@",
"-old logo",
].join("\n");

expect(parseTouchedFiles(diff)).toEqual([]);
});

it("keeps destination paths in headerless unified diffs", () => {
const diff = [
"--- /dev/null",
"+++ b/brand/logo.svg",
"@@ -0,0 +1 @@",
"+new logo",
].join("\n");

expect(parseTouchedFiles(diff)).toEqual([
{ path: "brand/logo.svg", patch: diff.split("\n").slice(1).join("\n") },
]);
});
});
Loading