Cargo feature for WASIp3 - #142
Open
adamrk wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Still investigating the test failure, but I was able to reproduce it on |
Contributor
Author
|
Fix for the test here: #143 |
pchickey
approved these changes
Sep 2, 2026
adamrk
force-pushed
the
abk/p3-feature-base
branch
from
September 3, 2026 14:24
170b21b to
ea32edf
Compare
adamrk
commented
Sep 3, 2026
Comment on lines
+3
to
+10
| fn main() { | ||
| cfg_aliases! { | ||
| // TODO https://github.com/bytecodealliance/wstd/issues/147: Swap these | ||
| // to use `target_env` instead. | ||
| p2: { feature = "p2" }, | ||
| p3: { feature = "p3" }, | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Saw this handy aliasing in #127 which can let us switch to using the target without a big diff. Not sure what our general philosophy is about pulling in entire crates for such little things though. I left it as a separate commit so it's easy to revert if we don't want it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
p2andp3features to target WASIp2 and WASIp3. These are temporary for developing the p3 backend and will eventually be removed in favor of usingtarget_os(see plan).(Probably this should be merged into a long running branch instead of
main, but I can't create one so just targetingmainfor now).Addresses #144