feat(log-viewer): inspector, grid ownership and VS Code web support - #1058
Closed
lukecotter wants to merge 8 commits into
Closed
lukecotter wants to merge 8 commits into
lukecotter wants to merge 8 commits into
Conversation
Five views each declared an identical find event type, and a sixth copy sat in the flame chart's types. One module now names them, keyed by event name so a listener's payload follows the name it subscribed to. Also drops a SearchOptions that collided by name with a different SearchOptions in the same feature folder.
…window Subscribes in hostConnected and unsubscribes in hostDisconnected, so a listener on a global target lives exactly as long as its host is connected. Handlers are passed as inline arrows: this package compiles with useDefineForClassFields:false, so a field initialiser cannot reference a field declared below it, and addEventListener with an undefined handler is a silent no-op. The constructor throws instead.
Seven views registered a global listener in the constructor and removed it in disconnectedCallback, so a re-attached view heard nothing. FindWidget never removed either of its two. Each view's event subset is unchanged. The adapter fields and the casts they needed are gone, and FindWidget now reads the shared results type rather than its own copy carrying a count no view sends.
The three tab views wired the inspector in their constructor and released it in disconnectedCallback, so a re-attached view lost mark, reveal and clear. The call moves beside wireCategoryColoring, which already had this shape, and all three constructors are now empty and gone. AnalysisView's suite mounted a bare element and relied on the constructor doing the wiring; it now attaches to the document and awaits updateComplete.
Detaching the view destroys its three tables, but the only build path runs when the log first arrives, so the view came back with its subscriptions and no table. It now rebuilds on connect, for the view on show, under the filters and grouping it was left with.
Five grids each carried their own copy of the column view, its overrides, and the reads and writes either side of them. One controller holds that now, so a grid declares only its section, presets and tables.
…d life Three views each held an emphasis, called the wiring by hand on connect and released it on disconnect. A controller does both now and owns the emphasis, since nothing outside the subscription decides what it holds. A view that comes back lights the pick again. The flame chart keeps the plain function: it is no Lit host, and rests the emphasis itself.
The abort listener stayed on the signal after the element came on screen, so the observer and the element it watched were held until the controller went.
lcottercertinia
added this pull request to stack #1060
September 17, 2026 14:13
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
The inspector work and everything that landed alongside it: 61 commits, 268 files. Pushed and opened for review as a whole, rather than left only on a laptop.
Written up from the commit history — worth a read-through before merging, since the branch spans several concerns.
🛠️ Changes made
Inspector
Timeline
Grids
Lifecycle
Performance
VS Code web
workspace.fs.🧩 Type of change (check all applicable)
🔗 Related Issues
See the individual commits; several carry their own issue references.
✅ Tests added?
📚 Docs updated?
Anything else we need to know? [optional]
PR #1059 stacks on this branch with two fixes for faults introduced here: the find-result panel on the Timeline, and a highlighted frame that could be lost on some themes. Merge this one first.