fix(log-viewer): keep a find match's panel up, and make a highlighted frame read on any theme - #1059
Closed
lukecotter wants to merge 2 commits into
Closed
lukecotter wants to merge 2 commits into
lukecotter wants to merge 2 commits into
Conversation
Stepping to a match centres the view, and the render that moves the frames asks the hit test again at the pointer. That answer took the match's own panel away, so the panel showed only when the pointer happened to rest off the chart. The chart now reports what changed the hover, and a panel opened by find or by the keyboard is held until the pointer moves or something else closes it.
The highlight takes its colour from the host's `editor.findMatchBackground`, a grey in several themes, and a search dims the frames around a match towards grey too, so the match could be lost among them. A frame too brief to carry a border got no border at all, leaving a hairline. Every highlight now carries a halo in the tone its colour is not, and a frame too thin to border is bordered at the width the wash widened it to. Both hairlines sit inside the frame's own row.
lcottercertinia
added this pull request to stack #1060
September 17, 2026 14:13
Collaborator
Author
|
Superseded by #1061, which puts the same two commits straight onto main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
Stepping through find results on the Timeline often showed no frame details panel, and the frame you were on could be lost among the frames around it on some themes.
Stacked on #1058, which is where both faults live — merge that one first.
🛠️ Changes made
editor.findMatchBackground— a grey in several themes — and a search dims the frames around a match towards grey too. Every highlight now carries a halo in the tone that colour is not. A frame too brief to carry a border got none at all; it is now bordered at the width the wash widened it to. Both hairlines sit inside the frame's own row, so a highlight no longer reaches into the rows above and below.🧩 Type of change (check all applicable)
🔗 Related Issues
None — both faults were found while testing the branch below.
✅ Tests added?
find-tooltip-hold.test.tscovers the hold, the handback and the three ways the panel closes;HighlightHalo.test.tscovers the halo tone either way and the bordered thin frame;HoverRehit.test.tscovers the cause the chart reports.📚 Docs updated?
Neither fault reached a release: the hover re-hit they both build on is unreleased.