refactor(log-viewer): give the grids one owner for their columns, and the inspector a connected life - #1062
Merged
lcottercertinia merged 3 commits intoSep 18, 2026
Conversation
Five grids each carried their own copy of the column view, its overrides, and the reads and writes either side of them. One controller holds that now, so a grid declares only its section, presets and tables.
…d life Three views each held an emphasis, called the wiring by hand on connect and released it on disconnect. A controller does both now and owns the emphasis, since nothing outside the subscription decides what it holds. A view that comes back lights the pick again. The flame chart keeps the plain function: it is no Lit host, and rests the emphasis itself.
The abort listener stayed on the signal after the element came on screen, so the observer and the element it watched were held until the controller went.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
Three commits that sit on top of #1048: the grids' columns get one owner, the inspector wiring follows the host's connected life, and a visibility wait releases its listener when it resolves.
Stacked on #1048 — merge that one first.
🛠️ Changes made
InspectorTabControllerties a tab's inspector wiring to the host's connected life, alongside the listener controllers refactor(log-viewer): tie global listeners to each view's connected life #1048 introduces, so nothing outlives the view that asked for it.🧩 Type of change (check all applicable)
🔗 Related Issues
None.
✅ Tests added?
InspectorTabController.test.tsand the sharedcontrollerHostStub.📚 Docs updated?