Skip to content

test: isolate validation from local model services - #2381

Merged
jonathanKingston merged 1 commit into
mainfrom
codex/isolate-tests-from-local-model
Sep 9, 2026
Merged

jonathanKingston merged 1 commit into
mainfrom
codex/isolate-tests-from-local-model

Conversation

@jonathanKingston

Copy link
Copy Markdown
Collaborator

Summary

  • prevent the remote-agent fallback unit test from probing a developer's LM Studio instance
  • inject the missing category classifier in the roadmap import fallback test so background work remains hermetic
  • seed E2E profiles with an unreachable local model URL by default while preserving explicit fixture overrides

Validation

  • pnpm test -- agent-service roadmap-issue-import provider-selection (93 tests passed with LM Studio running locally)
  • pnpm run check:e2e-syntax (268 files parsed)
  • pnpm run check (8,547 tests passed on the combined validated changeset)

@copse-release-bot

copse-release-bot Bot commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

Reference screenshots ready for review

Review GitHub’s image diffs in screenshot PR #2414.
Merge it (or enable auto-merge) to apply the accepted PNGs to codex/isolate-tests-from-local-model.

Rendered for ff5f8e6322e6 by CI run 34024329514; the immutable artifact is reference-screenshot-candidates-34024329514.

If this source branch moves, a later successful render closes the stale review PR and replaces this link.

@jonathanKingston

Copy link
Copy Markdown
Collaborator Author

Validation follow-up (2026-09-05): re-reviewed the isolation boundaries. The unit-test environment override is restored in finally; the E2E default remains overrideable by fixtures through the supported settings surface; and the missing category classifier removes the uncontrolled background provider path. The PR is mergeable, check is green, and all eight E2E shards passed. No further source changes needed.

@jonathanKingston
jonathanKingston force-pushed the codex/isolate-tests-from-local-model branch from 54cdffa to ff5f8e6 Compare September 6, 2026 09:19
github-actions Bot added a commit that referenced this pull request Sep 6, 2026
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

🖥️ PR preview

@jonathanKingston
jonathanKingston merged commit 9a4b028 into main Sep 9, 2026
22 of 23 checks passed
@jonathanKingston
jonathanKingston deleted the codex/isolate-tests-from-local-model branch September 9, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant