Skip to content

chore(e2e): review screenshots for #2381 - #2382

Closed
copse-release-bot[bot] wants to merge 2 commits into
codex/isolate-tests-from-local-modelfrom
screenshots/pr-2381/54cdfface9a8
Closed

copse-release-bot[bot] wants to merge 2 commits into
codex/isolate-tests-from-local-modelfrom
screenshots/pr-2381/54cdfface9a8

Conversation

@copse-release-bot

Copy link
Copy Markdown
Contributor

Screenshot candidates rendered for parent PR
#2381 at
54cdfface9a858e091cdfa423ea4ee6e3286cba9 by
CI run 33972660077.

Review GitHub's image diffs, then merge this PR (or enable auto-merge) to apply the
accepted references to codex/isolate-tests-from-local-model. This branch contains
only PNG candidates from the immutable
reference-screenshot-candidates-33972660077 artifact and never targets main.

If the parent branch has advanced beyond the source SHA above, do not merge this PR;
the successful CI run for the new head will replace it.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

🖥️ PR preview

@jonathanKingston

Copy link
Copy Markdown
Collaborator

Reviewed while validating parent #2381. The parent intentionally changes test isolation/configuration, not rendered UI. This candidate contains roughly 70 broad screenshot changes (including a new unrelated command-palette reference), so the image churn is not attributable to #2381 and should not be merged into the parent. Any genuine baseline refresh should be reviewed and landed separately with its originating UI change.

@jonathanKingston
jonathanKingston force-pushed the codex/isolate-tests-from-local-model branch from 54cdffa to ff5f8e6 Compare September 6, 2026 09:19

Copy link
Copy Markdown
Collaborator

Closing: these candidates predate #2398, which pinned every reference capture at a 2x device-pixel ratio. All 69 PNGs here were rendered at 1x, so merging this would push 1x baselines back onto codex/isolate-tests-from-local-model and undo the normalization on main.

Parent #2381 has been rebased onto current main, so its head has moved past the 54cdfface9a8 this branch is pinned to. CI on the new head re-renders the references at the pinned 2x and publishes a fresh review PR.


Generated by Claude Code

This branch was previously deployed

1 inactive deployment
github-pages — a9571a11 Deployed Sep 5, 2026 by copse-release-bot[bot] via deploy / deploy #3573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant