Align DWDS in the SDK with DWDS in Webdev - #2863
Open
Markzipan wants to merge 36 commits into
Open
Conversation
Markzipan
changed the title
Markzipan
force-pushed
the
hot_reload_and_eval_0
branch
7 times, most recently
from
August 12, 2026 00:43
89758f8 to
a48cdbe
Compare
Markzipan
force-pushed
the
hot_reload_and_eval_0
branch
from
August 12, 2026 17:28
a48cdbe to
1675629
Compare
biggs0125
requested changes
Aug 13, 2026
This reverts commit ba70df3.
github-actions
Bot
added
the
type-infra
…_uri_file_uri tests
…in BuildDaemonTestContext
… and add safe daemonClient closing
…tion resets under high load
biggs0125
reviewed
Aug 19, 2026
biggs0125
left a comment
biggs0125
left a comment
Contributor
There was a problem hiding this comment.
A couple notes:
- I'm having trouble identifying the delta here. You mentioned in your earlier comment that you changed some things in dwds_test_common but it's hard to know what those changes are.
- I'm still not clear on if we're actually landing the copied code in dwds_test_common vs just updating the SDK git pub target and landing changes in the SDK.
My ask here is that if there's a delta in dwds or dwds_test_common you open an SDK CL first with those changes. Even if you test it here in webdev, I think the delta will be much easier to see there.
| if: ${{ !contains(github.event.*.labels.*.name, 'changelog-not-required') }} | ||
| name: Maybe prevent submission | ||
| runs-on: ubuntu-latest | ||
| permissions: |
Contributor
There was a problem hiding this comment.
What's the context for all these workflow changes?
| - unit_test: | ||
| - group: | ||
| - command: Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 & | ||
| - command: echo "CHROME_EXECUTABLE=$(which google-chrome)" >> $GITHUB_ENV |
Contributor
There was a problem hiding this comment.
Should this be in this change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See for full discussion history: #2836
Aligns the external webdev repo with recent changes in the SDK: dart-lang/sdk@a9c6116
Changes not in the SDK:
frontend_server_common,asset_handler,dds_port,inspector, etc.) intodwds_test_commonfordwdsandwebdevaccess.dart_uri_file_uriserver path resolution to account for Build Daemon test contexts.