-
Notifications
You must be signed in to change notification settings - Fork 94
Align DWDS in the SDK with DWDS in Webdev #2863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Markzipan
wants to merge
36
commits into
dart-lang:main
Choose a base branch
from
Markzipan:hot_reload_and_eval_0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6,410
−3,672
Open
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
ff27dfa
Splitting more dwds tests between ddc module systems
Markzipan 1675629
Roll internal SDK dwds into webdev: Move common test files and flip t…
Markzipan 1817749
Fix missing changelog entry by merging Unreleased into 27.1.2
Markzipan f9f974a
Bump dwds version to 27.1.3-wip and update CHANGELOG
Markzipan 611b532
Refactor TestContext to be abstract and isolate Build Daemon logic
Markzipan cf385fc
Apply SDK style convention updates and fix context factories in tests
Markzipan f4c212a
Format files
Markzipan 9cc7753
Align DWDS with SDK and move custom tests to webdev
Markzipan b63fa79
Clean up dwds_test_common and move build helpers to webdev
Markzipan 12a75ef
Remove build_daemon dependency from dwds_test_common
Markzipan ba70df3
Skip DWDS/FES-only-specific tests in webdev
Markzipan e1e4146
Revert "Skip DWDS/FES-only-specific tests in webdev"
Markzipan 262772c
Run Xvfb for dwds Linux shards in CI
Markzipan 1789204
Merge remote-tracking branch 'origin/main' into hot_reload_and_eval_0
Markzipan 648e6dc
Fix Chrome resolution in CI Linux shards
Markzipan ebe6136
readding workflow fixes
Markzipan ecc7888
Restrict permissions in pull_request_label.yml
Markzipan d6dbd2e
Fix Chrome symlink paths in CI
Markzipan d9ff0f8
Use GITHUB_ENV to set CHROME_EXECUTABLE in CI
Markzipan fb5f022
Pass useDebuggerModuleNames to TestBuildSettings in test contexts
Markzipan 2b45d81
Format files
Markzipan e02bdfb
Resolve standard Windows Chrome installation paths in context.dart
Markzipan e88b1a9
Pass provider moduleFormat and canaryFeatures to TestSettings in dart…
Markzipan 9108780
Improve waitForAppId error reporting and diagnostic output
Markzipan 08324db
Fix appServerPath in dart_uri_file_uri and reset _expressionCompiler …
Markzipan 71096d5
Fix analysis issues in frontend_server_context and context.dart, and …
Markzipan ea3d016
Format code with dart format
Markzipan 063ddf3
Format code with modern dart format
Markzipan 5066aaf
Format debug_extension with modern dart format
Markzipan a734b33
Remove test_uri.dart scratch file
Markzipan a4ec052
Merge origin/main into hot_reload_and_eval_0
Markzipan a0264c1
Implement waitForSuccessfulBuild in BuildDaemonContextMixin
Markzipan c572c3d
Fix appServerPath in dart_uri_file_uri to check usesFrontendServer
Markzipan 2664155
Reduce concurrency in asset_handler test to prevent socket exhaustion…
Markzipan 9463daa
Wrap test IOClient with RetryClient to handle intermittent TCP connec…
Markzipan 43f819a
Log warning when retrying request on network error in RetryClient
Markzipan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the context for all these workflow changes?