Retarget changelog evaluate staging to changelog-ci/ - #308
Open
lcawl wants to merge 2 commits into
Open
Conversation
2 tasks
Mpdreamz
requested changes
Aug 24, 2026
Mpdreamz
left a comment
Member
There was a problem hiding this comment.
We deny hidden files and folders for a reason. This option should not exist in the first place IMO.
The output path shpuld be configured in the allowed set.
lcawl
force-pushed
the
hidden-directories-fix
branch
from
August 24, 2026 19:46
938a893 to
b467140
Compare
Contributor
Author
I've added b467140 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to elastic/docs-builder#3913 (merged).
Problem
changelog-submitwas writing staging/artifact files under.artifacts/.... That is a hidden directory, so:docs-builderScopedFileSystem rejected the path (fixed in docs-builder for callers that still use.artifacts).actions/upload-artifactskips hidden paths by default, so upload can fail with “no files found”.Using
include-hidden-files: truewas rejected in review: hidden dirs are denied for a reason; the output path should not require that option.Fix
Retarget evaluate staging/upload to a non-hidden in-repo directory:
changelog-ci/changelog-staging—mkdir,changelog add --output,prepare-artifact --staging-dirchangelog-ci/changelog-artifact—prepare-artifact --output-dir, upload-artifactpathArtifact name stays
changelog-staging, so apply still downloads to/tmp/changelog-stagingunchanged.No docs-builder changes are required for this path;
changelog-ci/is already in scope forChangelogFileSystem/RunnerTempFileSystem.Notes for reviewers
No per-repo setup is required for
changelog-ci/to work.Evaluate creates it on the runner with
mkdir -p changelog-ci/changelog-stagingafter checkout. That’s a normal writable workspace dir — no permissions, branch rules, or pre-created folder in the team repos.Nothing in that folder is committed. Apply only
git adds the real changelog YAML under the configured changelog directory (e.g.docs/changelog/…). Staging lives underchangelog-ci/on the evaluate job, is uploaded as thechangelog-stagingartifact, then apply unpacks it to/tmp/changelog-staging. The job workspace goes away when the run ends..gitignoreupdates are not required for the action. docs-content (for example) already ignores.artifacts, which covered the old path;changelog-ci/is a different name and isn’t needed for CI.Optional hygiene: add
changelog-ci/to a consumer.gitignoreonly if people might run the same local paths and accidentally commit junk. That’s convenience, not a prerequisite for using the action.