Allow .artifacts for changelog CI I/O - #3913
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
No actionable issues found. Verdict: approve.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
Mpdreamz
approved these changes
Aug 24, 2026
Contributor
Author
|
Rebase analysis:
|
lcawl
force-pushed
the
changelog-hidden-directories
branch
from
August 24, 2026 19:21
7d0b3cd to
a1297ce
Compare
lcawl
enabled auto-merge (squash)
August 24, 2026 19:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
changelog add --output .artifacts/changelog-staging(used by docs-actions changelog-submit) still fails when generation runs:ChangelogFileSystemrejects hidden.artifactspath segments. #3917 already fixed the overlappingprepare-artifact/RunnerTempFileSystempath.Also requires elastic/docs-actions#308 so
upload-artifactincludes files under.artifacts/changelog-artifact.Test plan
dotnet test tests/Elastic.Changelog.Tests/changelog-submitrun that does generate still succeeds end-to-endWhat
.artifactsonChangelogFileSystem(aligned with other scopes that already allow it)..artifacts, block other hidden dirs.