Add SDK versions 3.3.0, 3.3.1, and 3.4.0 to matrix

[markus-becker-tridonic-com]

No description provided.

[markus-becker-tridonic-com]

@beriberikix If I create a PR, the images are already pushed before the PR is merged. Should that be changed?

[markus-becker-tridonic-com]

Also note that Nordic ships an image themselves now:
https://github.com/nrfconnect/sdk-nrf/blob/main/scripts/docker/Dockerfile
https://github.com/nrfconnect/sdk-nrf/pkgs/container/sdk-nrf-toolchain

[beriberikix]

If I create a PR, the images are already pushed before the PR is merged. Should that be changed?

Good catch, and yes. The login and push guards in publish.yml were commented out, so push: true ran unconditionally — this PR published v3.3.0SDK, v3.3.1SDK and v3.4.0SDK to ghcr before it merged. embeddedcontainers/zephyr has the guards enabled; ncs had just drifted. Fixed in #13, which restores if: github.event_name != 'pull_request' on the login step and push: ${{ github.event_name != 'pull_request' }} on the build step. PRs will build only from now on.

Merged this — thanks. Note that a few patch releases are still missing from the matrix upstream: v3.2.5, v3.3.2, v3.3.3, v3.3.4. Happy to take a PR for those if you need them.

Also note that Nordic ships an image themselves now

Thanks, hadn't seen sdk-nrf-toolchain. Worth noting it's toolchain-only — their Dockerfile layers the toolchain in rather than shipping a ready NCS workspace — so it's complementary rather than a replacement.