ci: don't push images on pull requests - #13
Merged
Merged
Conversation
The registry login and push guards were commented out, so every PR published its matrix to ghcr.io before review. #12 added v3.3.0, v3.3.1 and v3.4.0, and all three tags were live in the registry before the PR merged. Restore the `github.event_name != 'pull_request'` guards so PRs build only, matching embeddedcontainers/zephyr. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The registry login and push guards in
publish.ymlwere commented out, sopush: trueran unconditionally and every PR published its full matrix to ghcr.io before review.This showed up in #12:
ghcr.io/embeddedcontainers/ncs:v3.3.0SDK,:v3.3.1SDKand:v3.4.0SDKwere all live in the registry before that PR merged, as @markus-becker-tridonic-com pointed out.This restores the guards:
if: github.event_name != 'pull_request'on the login steppush: ${{ github.event_name != 'pull_request' }}on the build stepmatching what
embeddedcontainers/zephyralready does. PRs now build only; pushes tomainstill publish.🤖 Generated with Claude Code