Repository navigation
fix(dep): Update to weval@0.5.0 and @bytecodealliance/jco@1.17.9 - #1601
Merged
Merged
Conversation
harmony7
force-pushed
the
kats/weval-dep-update
branch
from
October 9, 2026 05:53
007a342 to
922c472
Compare
harmony7
changed the title
zkat
changed the title
Removed fixed section and related entry from changelog.
zkat
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
@bytecodealliance/wevaldependency to 0.5.0. The fixnpm auditsuggests is a downgrade to 3.22.4 (from before weval was added), so users have no good way to clear the finding on their side.Before this PR,
@fastly/js-computedepends on@bytecodealliance/weval, which depends ondecompress@4.2.1.decompressis unmaintained and has a critical advisory, GHSA-mp2f-45pm-3cg9 / CVE-2026-53486 (archive extraction can write files and links outside the target directory). Every project that depends on@fastly/js-computegets a critical finding fromnpm audit.weval fixed this upstream in bytecodealliance/weval#32, which replaces
decompresswithtar+fflate. The fix shipped in weval v0.5.0 (2026-09-10) and closed bytecodealliance/weval#29.Before this PR:
After this PR:
@bytecodealliance/jco@1.7.0has the same problem and is fixed in 1.16 and later.package-lock.jsonhad already brought in^1.17.9, so this PR just updates the requirement as listed inpackage.json.Impact
decompressis only used by weval'sgetWeval(). That runs when the CLI first does an AOT compilation, which is now the default in 4.0.0. It unpacks the weval binary downloaded from the bytecodealliance/weval GitHub releases intonode_modules. It runs on the developer's machine or in CI, not inside the Compute sandbox. Exploiting the advisory would need a malicious archive to be served at that download URL, so the practical risk is low. The audit finding is still critical, and it affects every downstream project.