fix: correct the fluent-operator deployment to match the setup.yaml with helm template - #2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Kustomize-based installation manifests to align the Fluent Operator manager Deployment and metrics Service with the Helm chart defaults, addressing a startup regression caused by secure metrics certificate generation on a read-only filesystem.
Changes:
- Aligns the manager Deployment spec (entrypoint usage, container name, env, probes, resources, and security contexts) with Helm defaults.
- Switches the metrics Service from HTTPS/8443 to a metrics port on 8080 and documents HTTPS metrics as an optional patch path.
- Regenerates the published
manifests/setup/setup.yamlbundle from the updated Kustomize config.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
config/manager/manager.yaml |
Reworks the manager Deployment to match Helm defaults (entrypoint/args, ports, security context, probes, resources). |
config/default/kustomization.yaml |
Stops enabling secure metrics by default and updates guidance for optional HTTPS metrics patches. |
config/default/metrics_service.yaml |
Changes the metrics Service port/name to metrics:8080. |
manifests/setup/setup.yaml |
Regenerated install bundle reflecting the updated Kustomize Deployment and Service. |
marcofranssen
previously approved these changes
Aug 4, 2026
marcofranssen
self-requested a review
August 4, 2026 10:07
marcofranssen
enabled auto-merge (squash)
August 4, 2026 10:07
Signed-off-by: Chengwei Guo <cwguoz@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Josh Baird <jbaird@galileo.io> Signed-off-by: Chengwei Guo <cwguoz@gmail.com>
Signed-off-by: Chengwei Guo <cwguoz@gmail.com>
joshuabaird
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Fixes the YAML-based installation regression reported in #1995.
Since #1953,
manifests/setup/setup.yamlhas been generated from the Kustomize configuration. However, the manager Deployment inconfig/manager/manager.yamlwas not aligned with the Helm chart defaults.The generated Deployment explicitly enabled the secure metrics endpoint on port
8443while using a read-only root filesystem. Without a provided certificate, controller-runtime attempts to generate certificates under/tmp/k8s-metrics-server, which can prevent the operator from starting.This PR aligns the default Kustomize Deployment with the Deployment produced by Helm:
/managerentrypoint instead of overridingcommand.fluent-operatorcontainer name.CONTAINER_LOG_PATH.8080.Which issue(s) this PR fixes
Fixes #1995
Files updated
config/manager/manager.yamlconfig/default/kustomization.yamlconfig/default/metrics_service.yaml8443to the Helm default port8080.manifests/setup/setup.yamlValidation
helm templateusing the default values.make test-e2e: all 10 Fluentd e2e specs passed.commandorargs.Does this PR introduce a user-facing change?