Skip to content

security(ci): pin GitHub Actions to commit SHAs and fix template injection #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xavidop merged 1 commit into from
Aug 31, 2026
Merged

security(ci): pin GitHub Actions to commit SHAs and fix template injection #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,24 +24,24 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v7
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7

- name: Set up JDK 21
uses: actions/setup-java@v5
uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5
with:
java-version: '21'
distribution: 'temurin'
cache: maven

- name: Initialize CodeQL
uses: github/codeql-action/init@v4
uses: github/codeql-action/init@cdf488f595d80d6e07e03d4674febd5ab45fa938 # v4
with:
languages: ${{ matrix.language }}

- name: Build with Maven
run: mvn clean install -DskipTests

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v4
uses: github/codeql-action/analyze@cdf488f595d80d6e07e03d4674febd5ab45fa938 # v4
with:
category: "/language:${{matrix.language}}"
8 changes: 4 additions & 4 deletions .github/workflows/java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#
# SPDX-License-Identifier: Apache-2.0

name: Java tests and checks

Check warning on line 17 in .github/workflows/java.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

excessive-permissions 

java.yml:17: overly broad permissions: default permissions used due to no permissions: block

on:
pull_request:
Expand All @@ -22,17 +22,17 @@
branches:
- main
jobs:
build:

Check warning on line 25 in .github/workflows/java.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

excessive-permissions 

java.yml:25: overly broad permissions: default permissions used due to no permissions: block
runs-on: ubuntu-latest
strategy:
matrix:
java-version: ['21']
steps:
- name: Checkout Repo
uses: actions/checkout@v7
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7

- name: Set up JDK ${{ matrix.java-version }}
uses: actions/setup-java@v5
uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5
with:
java-version: ${{ matrix.java-version }}
distribution: 'temurin'
Expand All @@ -44,14 +44,14 @@
- name: Run tests
run: mvn -B test

lint:

Check warning on line 47 in .github/workflows/java.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

excessive-permissions 

java.yml:47: overly broad permissions: default permissions used due to no permissions: block
runs-on: ubuntu-latest
steps:
- name: Checkout Repo
uses: actions/checkout@v7
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7

- name: Set up JDK 21
uses: actions/setup-java@v5
uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5
with:
java-version: '21'
distribution: 'temurin'
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/publish-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
# Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages
permissions:
contents: read
pages: write

Check failure on line 27 in .github/workflows/publish-docs.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

excessive-permissions 

publish-docs.yml:27: overly broad permissions: pages: write is overly broad at the workflow level
id-token: write

Check failure on line 28 in .github/workflows/publish-docs.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

excessive-permissions 

publish-docs.yml:28: overly broad permissions: id-token: write is overly broad at the workflow level

# Allow only one concurrent deployment
concurrency:
Expand All @@ -37,17 +37,17 @@
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v7
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7

- name: Set up JDK 21
uses: actions/setup-java@v5
uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5
with:
java-version: "21"
distribution: "temurin"
cache: "maven"

- name: Set up Node.js
uses: actions/setup-node@v7
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
with:
node-version: "22"
cache: "npm"
Expand All @@ -72,7 +72,7 @@
cp -r target/site/apidocs/* docs/dist/javadoc/ 2>/dev/null || true

- name: Upload artifact
uses: actions/upload-pages-artifact@v5
uses: actions/upload-pages-artifact@fc324d3547104276b827a68afc52ff2a11cc49c9 # v5
with:
path: docs/dist

Expand All @@ -85,4 +85,4 @@
steps:
- name: Deploy to GitHub Pages
id: deployment
uses: actions/deploy-pages@v5
uses: actions/deploy-pages@cd2ce8fcbc39b97be8ca5fce6e763baed58fa128 # v5
17 changes: 9 additions & 8 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@
- major

permissions:
contents: write

Check failure on line 37 in .github/workflows/release.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

excessive-permissions 

release.yml:37: overly broad permissions: contents: write is overly broad at the workflow level
packages: write

Check failure on line 38 in .github/workflows/release.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

excessive-permissions 

release.yml:38: overly broad permissions: packages: write is overly broad at the workflow level
pull-requests: write

Check failure on line 39 in .github/workflows/release.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

excessive-permissions 

release.yml:39: overly broad permissions: pull-requests: write is overly broad at the workflow level

jobs:
release:
Expand All @@ -47,13 +47,13 @@
tag_name: ${{ steps.release.outputs.tag_name }}
steps:
- name: Checkout Repo
uses: actions/checkout@v7
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
fetch-depth: 0

- name: Release Please
id: release
uses: googleapis/release-please-action@v5
uses: googleapis/release-please-action@45996ed1f6d02564a971a2fa1b5860e934307cf7 # v5
with:
token: ${{ secrets.GITHUB_TOKEN }}
release-type: maven
Expand All @@ -66,12 +66,12 @@
runs-on: ubuntu-latest
steps:
- name: Checkout Repo
uses: actions/checkout@v7
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
ref: ${{ needs.release.outputs.tag_name }}

- name: Set up JDK 21
uses: actions/setup-java@v5
uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5
with:
java-version: '21'
distribution: 'temurin'
Expand All @@ -81,9 +81,10 @@
server-password: GITHUB_TOKEN

- name: Update version in pom.xml files
env:
VERSION: ${{ needs.release.outputs.version }}
run: |
VERSION=${{ needs.release.outputs.version }}
mvn versions:set -DnewVersion=${VERSION} -DgenerateBackupPoms=false
mvn versions:set -DnewVersion="${VERSION}" -DgenerateBackupPoms=false

- name: Build with Maven
run: mvn -B clean compile -DskipTests
Expand All @@ -103,10 +104,10 @@
runs-on: ubuntu-latest
steps:
- name: Checkout Repo
uses: actions/checkout@v7
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7

- name: Set up JDK 21
uses: actions/setup-java@v5
uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5
with:
java-version: '21'
distribution: 'temurin'
Expand Down
Loading